Be able to build examples with static client #51
Conversation
example/CMakeLists.txt
Outdated
| # target_link_libraries (${basename} rocketmq_static ${deplibs}) | ||
| #endif() | ||
| else() | ||
| target_link_libraries (${basename} rocketmq_static ${deplibs} ${Boost_LIBRARIES} ${LIBEVENT_LIBRARIES} ${JSONCPP_LIBRARIES}) |
There was a problem hiding this comment.
I think boost libraries, libevent, and jsonncpp library don't need to be linked again, as they are linked to rocketmq_static before.
Could you please remove "${Boost_LIBRARIES} ${LIBEVENT_LIBRARIES} ${JSONCPP_LIBRARIES}" and have a test on it?
There was a problem hiding this comment.
I have tested ”PullConsumer“。
I know why these libraries didn't automaically add to dependent library list while compiling PullConsumer linking static mqclient, it's because we didn't link these object while compiling static mqclient.
By the way, I just learn that when we use 'target_link_libraries' on static library, cmake dosn't really link these library on target library, it just remember the dependency of the target library on its own.
https://stackoverflow.com/questions/52038439/static-libraries-linked-against-other-static-libraries-with-cmake-one-works-o
stcai
force-pushed
the
be-able-to-build-example-with-static-client
branch
from
b40c5a4 to
87768ee
Compare
stcai
changed the title
Be able to build examples while cmake option "BUILD_ROCKETMQ_SHARED" is turned off.