[SPARK-51890][SQL] Add New Parameter options to Logical Plan View.
#50645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yumingxuanguo-db
changed the title
options to Logical Plan View.
|
Mind adding a test and filing a JIRA please? see also https://spark.apache.org/contributing.html |
yumingxuanguo-db
changed the title
options to Logical Plan View.options to Logical Plan View.
cloud-fan
approved these changes
Apr 29, 2025
|
thanks, merging to master! |
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
May 5, 2025
### What changes were proposed in this pull request? Adds a new parameter `options: CaseInsensitiveStringMap` to the case class of logical plan `View`. Changed a few pattern matching along the way. ### Why are the changes needed? User specified options when reading views can be stored for later use. I.e., ``` SELECT * FROM view WITH (foo = bar) ``` ### Does this PR introduce _any_ user-facing change? Yes. The pattern matching on `View` now takes four arguments instead of three. ### How was this patch tested? UTs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50645 from yumingxuanguo-db/dev/add-options-to-view. Authored-by: Yumingxuan Guo <a.guo@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Kimahriman
pushed a commit
to Kimahriman/spark
that referenced
this pull request
May 13, 2025
### What changes were proposed in this pull request? Adds a new parameter `options: CaseInsensitiveStringMap` to the case class of logical plan `View`. Changed a few pattern matching along the way. ### Why are the changes needed? User specified options when reading views can be stored for later use. I.e., ``` SELECT * FROM view WITH (foo = bar) ``` ### Does this PR introduce _any_ user-facing change? Yes. The pattern matching on `View` now takes four arguments instead of three. ### How was this patch tested? UTs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50645 from yumingxuanguo-db/dev/add-options-to-view. Authored-by: Yumingxuan Guo <a.guo@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds a new parameter
options: CaseInsensitiveStringMapto the case class of logical planView. Changed a few pattern matching along the way.Why are the changes needed?
User specified options when reading views can be stored for later use. I.e.,
Does this PR introduce any user-facing change?
Yes. The pattern matching on
Viewnow takes four arguments instead of three.How was this patch tested?
UTs.
Was this patch authored or co-authored using generative AI tooling?
No.