Skip to content

[SPARK-51921][SS][PYTHON][4.0] Use long type for TTL duration in millisecond in transformWithState #50745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

bogao007
Copy link
Contributor

@bogao007 bogao007 commented Apr 28, 2025

What changes were proposed in this pull request?

  • Use long type (int64 for protobuf) for TTL duration in millisecond
  • Fixed test_transform_with_map_state_metadata test case.

Why are the changes needed?

Allow users to set longer period of time for TTL duration.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Updated test case

Was this patch authored or co-authored using generative AI tooling?

No

@bogao007 bogao007 changed the title Use long type for TTL duration in millisecond in transformWithState [SPARK-51921][SS][PYTHON] Use long type for TTL duration in millisecond in transformWithState Apr 28, 2025
@HyukjinKwon HyukjinKwon changed the title [SPARK-51921][SS][PYTHON] Use long type for TTL duration in millisecond in transformWithState [SPARK-51921][SS][PYTHON][4.0] Use long type for TTL duration in millisecond in transformWithState Apr 28, 2025
@HyukjinKwon
Copy link
Member

cc @HeartSaVioR

Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@HeartSaVioR
Copy link
Contributor

https://github.com/bogao007/spark/runs/41311375745

This only failed from docker integration module.

@HeartSaVioR
Copy link
Contributor

Thanks! Merging to 4.0.

HeartSaVioR pushed a commit that referenced this pull request Apr 29, 2025
…isecond in transformWithState

### What changes were proposed in this pull request?

- Use long type (int64 for protobuf) for TTL duration in millisecond
- Fixed `test_transform_with_map_state_metadata` test case.

### Why are the changes needed?

Allow users to set longer period of time for TTL duration.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Updated test case

### Was this patch authored or co-authored using generative AI tooling?

No

Closes #50745 from bogao007/ttl-4.0.

Authored-by: bogao007 <bo.gao@databricks.com>
Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants