feat: remove libexpat dependency #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luacheck Report5 tests 5 ✅ 0s ⏱️ Results for commit 3b8fc8f. ♻️ This comment has been updated with latest results. |
juzhiyuan
reviewed
Aug 9, 2024
| @@ -314,6 +312,7 @@ describe("operations protocol", function() | |||
|
|
|||
| assert.same({ | |||
| headers = { | |||
| ["Accept"] = 'application/json', | |||
There was a problem hiding this comment.
Clever and this would be much better!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Lua files are using the XML-based AWS STS API, and they require bindings based on the libexpat c library to parse the XML, which requires that the expat library be installed for OpenResty; this library has a specific requirement for a version of the expat codebase, which is not available in the repositories of the major Linux distributions, and can only be installed from source. This creates a barrier to building and distributing the software.
However that the AWS STS API doesn't have to use XML as a response format, it also supports JSON, allowing us to parse it directly in cjson.
This PR makes the change to remove the expat dependency and change the two Credentials methods that currently rely on XML to JSON. This will modify the request headers on all service API calls, but is not expected to have an impact since those APIs originally used JSON.