Updated twitter-bootstrap library to version 4 #39
Conversation
|
|
|
Whoa!!! I have been dreading this. Thank you! I will give it a whirl soon and would then merge it. |
|
@DonMartin76 Thank you for developing this excellent project and hope to be able to contribute more |
There was a problem hiding this comment.
Amazing work! Thanks! I still see a couple of things which are slightly off:
Gap between menu line and content, color of menu bar
On some pages, there is a gap between the menu bar and the actual content of the page. This does not look good.
Additionally, the color of the menu bar has changed; it is now grey (which I suppose is the default of bootstrap 4). This means we need an update step of the static configuration to add the customized color in the wicked.css file. If you can tell me which classes need to be overwritten, or add a class for the menu bar which we can add to the wicked.css file, then I can do the update step in wicked.portal-env.
Default home page is broken
There are a couple of things which are broken with the default "main"/Home page of the static configuration:
- The wicked logo is not centered
- The arrows showing the "workflow" are not aligned as before, probably the layouting has changed from Bootstrap 3 to 4
This has to be changed in the wicked.portal-env repository, which is where the standard static configuration is checked in.
Panel/Card/Button colors very strong
I guess this is a new default in Bootstrap, and I have to get used to it, but the danger/success/primary/... classes in Bootstrap 4 are a lot stronger than with Bootstrap 3, which had a "pastel" kind of look and feel. The only issue with this is that most other default colors are adapted to this "pastel" look and feel, and this some thing are a bit weird in combination with the new Bootstrap 4 colors:
Is there a way to get back the Bootstrap 3 colors? I guess not, but then we should perhaps adapt the default colors in the static configuration.
|
@DonMartin76 That's right. I'll fix them asap. Some minor changes is required also in the wicked-sample-config project. I'll fill a pull request for those changes in that repo. |
|
@DonMartin76 I'm confused about static content files. For example, there is two wicked.css files:
Which one is the right place to edit? |
|
In both. Wicked sample config is a sample config for running a quick setup
of wicked. In Portal-env is the Template for new configurations which are
created via the portal Kickstarter. The latter is more important.
Armin Rezayati <notifications@github.com> schrieb am So. 9. Dez. 2018 um
13:13:
… @DonMartin76 <https://github.com/DonMartin76> I'm confused about static
content files. For example, there is two *wicked.css* files:
1. wicked-sample-config */static/content/wicked.css*
2. wicked.portal-env */initial-config/static/content/wicked.css*
Which one is the right place to edit?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#39 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG_Mo98vhcMBArWZj4zATVsVG8KqwYqsks5u3P59gaJpZM4ZGYz0>
.
|
|
I've fixed positioning and alignment issues. (no pull-request yet) see the following image:
But the colors...it's another story. Generally, in BS4 colors are much more brighter and saturated. For example these are the default background colors: We have these solutions:
|
|
Looks good! Thanks! I guess we will stick with the new default colors. As
you say, changing those would bring a lot of work, and also introduce
unnecessary maintenance to the project. We could add guidance on how to get
the colors back perhaps, but state that it will mean you need to maintain
them yourself. That should be possible, right? By overriding certain
classes via wicked.css?
Armin Rezayati <notifications@github.com> schrieb am So. 9. Dez. 2018 um
20:58:
… *I've fixed positioning and alignment issues.* (no pull-request yet) see
the following image:
[image: screenshot from 2018-12-09 23-13-23]
<https://user-images.githubusercontent.com/2006991/49701963-19f19200-fc08-11e8-9ff5-bc90057181d9.png>
*But the colors...it's another story.* Generally, in BS4 colors are much
more brighter and saturated. For example these are the default background
colors:
[image: screenshot from 2018-12-09 23-17-29]
<https://user-images.githubusercontent.com/2006991/49701994-a69c5000-fc08-11e8-8497-755620b8fc6e.png>
*We have these solutions:*
- For individual elements, like the top menu bar we are able to
restore the old style by add/modify some styles in *wicked.css*.
- For general elements, like buttons - cards (panels in bs3) - etc, we
should stick to the new default colors or develop a new bootstrap theme or
even use one the available bootswatch.com themes.
Develop a new theme, even a simplistic one, would require a lot of
work. Using bootswatch themes is the simplest solution, but it would change
all the look and feel of UI .
What do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#39 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG_MozcvfvLCPrl0BpCWdh2yhj9UijlTks5u3Wt9gaJpZM4ZGYz0>
.
|
|
I've committed last changes in this pull request. Also filled two pull requests for both
Yes, one can override classes in wicked.css. I'll maintain required help docs. |
all required changes made into portal templates according to the migration path: https://getbootstrap.com/docs/4.1/migration/#stable-changes
…-bootstrap 4 styles
armezit
force-pushed
the
twitter-bootstrap-4
branch
from
a33dd91 to
5f7a97a
Compare
Updated twitter-bootstrap library to version 4
all required changes made into portal templates according to the migration guideline:
https://getbootstrap.com/docs/4.1/migration/#stable-changes