Skip to content

test_preceding_whitespace fails on Python 3.13 #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dotlambda opened this issue Apr 15, 2025 · 3 comments
Open

test_preceding_whitespace fails on Python 3.13 #199

dotlambda opened this issue Apr 15, 2025 · 3 comments

Comments

@dotlambda
Copy link

... because

The compiler now strips common leading whitespace from every line in a docstring.

See https://docs.python.org/3/whatsnew/3.13.html#other-language-changes.

@JayBazuzi
Copy link
Contributor

python/cpython#81283 (comment).

Chance of breaking things with this change? not impossible, but extremely minor. Something using docstrings as data and depending on leading indentation whitespace preservation would not like this. I am not aware of anything that would ever do that.

Ouch.

@JayBazuzi
Copy link
Contributor

Temporarily disabled this test under Python 3.13 to unblock CI. See be07544.

@nitsanavni
Copy link
Contributor

IMHO this docstring limitation is acceptable for inline approvals.
If the user needs to verify whitespace in fine detail, we should recommend non-inline approvas for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants