Fix "attributes" typing for Node and Web SDKs #1037
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In our swagger specs, we have defined the typings for an attribute to be attributeBoolean, attributeInteger and so on... but in SDK generator although we have the typings defined, we default
attribute
's typing to an array of strings instead of using the defined typings.This PR adds check if typings exist in "anyOf" field of the spec, and use those as a union.
Test Plan
Before:
After:
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes.