feat: add name and labels in cluster metrics (#17870)

[flbla]

Closes #17870

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.

#18452 #17870 #9731

[codecov]

Codecov Report

Attention: Patch coverage is 93.40659% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.51%. Comparing base (e147247) to head (94d1e8c).
Report is 377 commits behind head on master.

Files with missing lines	Patch %	Lines
controller/metrics/clustercollector.go	92.85%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #18453      +/-   ##
==========================================
- Coverage   55.51%   55.51%   -0.01%     
==========================================
  Files         339      339              
  Lines       57273    57346      +73     
==========================================
+ Hits        31797    31837      +40     
- Misses      22790    22820      +30     
- Partials     2686     2689       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aliazlan-t]

This will be great. Any idea about what is pending and when can this be merged?

[flbla]

hi @aliazlan-t,
I think we need to find a maintainer to review it
I tried to link all issues I found but for now without success

[flbla]

@rumstead, I updated the metrics according to the comment of @agaudreault

[agaudreault]

Changes for the name lgtm 👍 However, I think the labels should be in a new metric.

[poliveirabp]

Hi guys, this is an awesome feature, there is any date on mind when this is becoming live?

[flbla]

Hi @agaudreault @rumstead @reggie-k
I rebased my PR.
could you please take a look at it? 🙏
thank you!

[nitishfy]

can you fix the failing CI checks?

[flbla]

can you fix the failing CI checks?

@nitishfy could you please help me with the e2e failing tests I'm not sure it's due to my changes ? thank you

---edit

I rebased my branch, all tests are success

[agaudreault]

@flbla I will push some update for the review directly on the PR. I think we can merge faster this way than avoiding another full review loop. Good refactor since my last review 💯

[agaudreault]

@flbla it would seem like you created a PR from your fork master branch directly which prevent me from pushing modifications. Can you add me as a contributor in your fork/branch protection, or merge the PR on your fork?

The github setting "Maintainers are allowed to edit this pull request." wont work for master branch.

[flbla]

@agaudreault, okay, thank you
I merged your changes (and also added you as contributor if you need to change something else)

[rumstead]

LGTM - thanks for making your first contribution!

EDIT: seems odd the linter is picking up unchanged files? Maybe a retrigger would help based on this comment in golangci?