Add LLVM libc based toolchain build #270
Conversation
Add build script for ATfE variant with LLVM libc as the defaulty C library to simplify testing project compatibility with LLVM libc. Update CMake file to give the package an informative name.
| export CXX=clang++ | ||
|
|
||
| SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) | ||
| REPO_ROOT=$( git -C ${SCRIPT_DIR} rev-parse --show-toplevel ) |
There was a problem hiding this comment.
Shell quoting nits: ${SCRIPT_DIR} in this line should be double-quoted. So should ${BUILD_DIR} in the mkdir and cd commands below.
(But it's OK not to quote these $(...) constructs on the RHS of an assignment, or the ${REPO_ROOT} in the assignment to BUILD_DIR, because in that context, the shell decides what's the RHS of a variable assignment before expanding those things into stuff that might contain spaces.)
There was a problem hiding this comment.
Since @voltur01 is on holiday this week and I'm on holiday next week, in the interests of moving things along, I'll change my mind and approve this PR, then submit my own followup which fixes the quoting, in this file and several others with the same issue.
While reviewing #270 I noticed some missing quotes in the new script, and David spotted that that's because they're the same in all the other similar scripts. Fix the whole lot. Building in a spacey directory might fail anyway (quite likely _something_ in the overall build edifice isn't prepared to cope). But we can at least fix the issues we find.
|
Thank you @statham-arm! Note that we have the same code in other build scripts, so may need to review all of them. |
Add build script for ATfE variant with LLVM libc as the defaulty C library to simplify testing project compatibility with LLVM libc.
Update CMake file to give the package an informative name.