Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armbian-install: disable Docker when installing images #7915

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Mar 6, 2025

Description

Stop Docker system running Armbina-install to prevent weird results and to speed up. Does it make sense?

How Has This Been Tested?

  • Manual test, disabling and installing to eMMC, reboot, works

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik added Work in progress Unfinished / work in progress Discussion Being discussed - Voice your opinions :) labels Mar 6, 2025
@igorpecovnik igorpecovnik requested a review from a team as a code owner March 6, 2025 14:19
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review BSP Board Support Packages labels Mar 6, 2025
@igorpecovnik igorpecovnik force-pushed the disable_docker branch 2 times, most recently from b1c008d to b50ac8d Compare March 9, 2025 09:27
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 05 Milestone: Second quarter release and removed Discussion Being discussed - Voice your opinions :) Needs review Seeking for review labels Mar 17, 2025
@github-actions github-actions bot added Needs review Seeking for review and removed Ready to merge Reviewed, tested and ready for merge labels Mar 19, 2025
@rpardini
Copy link
Member

weird results and to speed up. Does it make sense?

Weird results all the time, as armbian-install does an rsync of a running system -- many things can be open and change during the rsync. I think Docker (containerd, really) and its overlay2 filesystem might just be wors-er than most, but the wierdness can happen with many other things.

@rpardini
Copy link
Member

The "correct" way of doing this involves creating a temporary initrd and kexec'ing into a new kernel and initrd while leaving the original image unmounted, so that it can be copied without anything open or running on it. It is a huge endeavour though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 Milestone: Second quarter release BSP Board Support Packages Needs review Seeking for review size/small PR with less then 50 lines Work in progress Unfinished / work in progress
Development

Successfully merging this pull request may close these issues.

2 participants