Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mekotronics-rk3588: u-boot: back to radxa's v2024.03, as .10 breaks GMAC stable MAC patch #7971

Merged
merged 1 commit into from
Mar 19, 2025
Merged

mekotronics-rk3588: u-boot: back to radxa's v2024.03, as .10 breaks GMAC stable MAC patch #7971

merged 1 commit into from
Mar 19, 2025

Conversation

rpardini
Copy link
Member

  • this reverts d048673 just for the Meko's
  • there is little to be gained from .10 anyway on those machines (IMHO)
  • it is still vendor 2017.09 after all, dunno why Radxa calls them "2024.x"

@rpardini
mekotronics-rk3588: u-boot: back to radxa's v2024.03, as .10 breaks G…
f9710a8 
…MAC stable MAC patch

- this reverts d048673 just for the Meko's
- there is little to be gained from .10 anyway on those machines (IMHO)
- it is still vendor 2017.09 after all, dunno why Radxa calls them "2024.x"
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Mar 18, 2025
@rpardini
Copy link
Member Author

With v2024.10, my (admittedly lacking) stable-MAC patch fails to actually set the macs in the environment:

rockchip_set_ethaddr: going for vendor_storage_read
rockchip_set_ethaddr: vendor_storage_read returned 12
rockchip_set_ethaddr: looping... 0 and ret 12
rockchip_set_ethaddr: setting in env
## Error: Can't overwrite "ethaddr"
## Error inserting "ethaddr" variable, errno=1
rockchip_set_ethaddr: looping... 1 and ret 12
rockchip_set_ethaddr: setting in env
## Error: Can't overwrite "eth1addr"
## Error inserting "eth1addr" variable, errno=1

Full bootlogs:

With v2024.10:

U-Boot 2017.09-armbian (Feb 16 2025 - 17:08:50 -0300)

Model: Mekotronics R58X-4G (RK3588 EDGE LP4x V1.2 BlueBerry Board)
MPIDR: 0x0
PreSerial: 2, raw, 0xfeb50000
DRAM:  8 GiB
Sysmem: init
Relocation Offset: eda0f000
Relocation fdt: eb9f92f0 - eb9fecc8
CR: M/C/I
usb dr_mode not found
Using default environment

DM: v2
mmc@fe2c0000: 1, mmc@fe2e0000: 0
Bootdev(atags): mmc 0
MMC0: HS200, 200Mhz
PartType: EFI
No misc partition
boot mode: normal
FIT: No boot partition
Failed to load DTB, ret=-2
No valid DTB, ret=-22
Failed to get kernel dtb, ret=-22
Model: Mekotronics R58X-4G (RK3588 EDGE LP4x V1.2 BlueBerry Board)
rockchip_set_serialno: starting serial number code
rockchip_set_ethaddr: starting ethernet MAC set
rockchip_set_ethaddr: serial# for eth base is 396c46e7b45f06f1
rockchip_set_ethaddr: checksumming serial digit 0
rockchip_set_ethaddr: checksumming serial digit 1
rockchip_set_ethaddr: checksumming serial digit 2
rockchip_set_ethaddr: checksumming serial digit 3
rockchip_set_ethaddr: checksumming serial digit 4
rockchip_set_ethaddr: checksumming serial digit 5
rockchip_set_ethaddr: checksumming serial digit 6
rockchip_set_ethaddr: checksumming serial digit 7
rockchip_set_ethaddr: checksumming serial digit 8
rockchip_set_ethaddr: checksumming serial digit 9
rockchip_set_ethaddr: checksumming serial digit 10
rockchip_set_ethaddr: checksumming serial digit 11
rockchip_set_ethaddr: checksumming serial digit 12
rockchip_set_ethaddr: checksumming serial digit 13
rockchip_set_ethaddr: checksumming serial digit 14
rockchip_set_ethaddr: checksumming serial digit 15
rockchip_set_ethaddr: going for vendor_storage_read
rockchip_set_ethaddr: vendor_storage_read returned 12
rockchip_set_ethaddr: looping... 0 and ret 12
rockchip_set_ethaddr: setting in env
## Error: Can't overwrite "ethaddr"
## Error inserting "ethaddr" variable, errno=1
rockchip_set_ethaddr: looping... 1 and ret 12
rockchip_set_ethaddr: setting in env
## Error: Can't overwrite "eth1addr"
## Error inserting "eth1addr" variable, errno=1
setup_download_mode checking if download is NOT HOTkey pressed...
CLK: (sync kernel. arm: enter 1008000 KHz, init 1008000 KHz, kernel 0N/A)
  b0pll 24000 KHz
  b1pll 24000 KHz
  lpll 24000 KHz
  v0pll 24000 KHz
  aupll 24000 KHz
  cpll 1500000 KHz
  gpll 1188000 KHz
  npll 24000 KHz
  ppll 1100000 KHz
  aclk_center_root 702000 KHz
  pclk_center_root 100000 KHz
  hclk_center_root 396000 KHz
  aclk_center_low_root 500000 KHz
  aclk_top_root 750000 KHz
  pclk_top_root 100000 KHz
  aclk_low_top_root 396000 KHz
Net:   No ethernet found.
Hit key to stop autoboot('CTRL+C'):  0
starting USB...
Bus usb@fcd00000: Register 2000140 NbrPorts 2
Starting the controller
USB XHCI 1.10
scanning bus usb@fcd00000 for devices... 1 USB Device(s) found
       scanning usb for storage devices... 0 Storage Device(s) found

Device 0: unknown device
MMC: no card present
mmc_init: -123, time 1
pcie@fe150000: PCIe Linking... LTSSM is 0x1
pcie@fe150000: PCIe Linking... LTSSM is 0x210022
pcie@fe150000: PCIe Linking... LTSSM is 0x210022
pcie@fe150000: PCIe Linking... LTSSM is 0x210023
pcie@fe150000: PCIe Link up, LTSSM is 0x230011
pcie@fe150000: PCIE-0: Link up (Gen3-x4, Bus0)

Device 0: Vendor: 0x15b7 Rev: 281010WD Prod: 23285G403448
            Type: Hard Disk
            Capacity: 953869.7 MB = 931.5 GB (1953525168 x 512)
... is now current device
Scanning nvme 0:1...
Found U-Boot script /boot/boot.scr
4149 bytes read in 2 ms (2 MiB/s)
## Executing script at 00500000
Boot script loaded from nvme 0:1
177 bytes read in 2 ms (85.9 KiB/s)
14619419 bytes read in 16 ms (871.4 MiB/s)
48554496 bytes read in 50 ms (926.1 MiB/s)
272881 bytes read in 19 ms (13.7 MiB/s)
Trying kaslrseed command... Info: Unknown command can be safely ignored since kaslrseed does not apply to all boards.
Unknown command 'kaslrseed' - try 'help'
Fdt Ramdisk skip relocation
No misc partition
## Loading init Ramdisk from Legacy Image at 0a200000 ...
   Image Name:   uInitrd
   Image Type:   AArch64 Linux RAMDisk Image (gzip compressed)
   Data Size:    14619355 Bytes = 13.9 MiB
   Load Address: 00000000
   Entry Point:  00000000
   Verifying Checksum ... OK
## Flattened Device Tree blob at 0x08300000
   Booting using the fdt blob at 0x08300000
   reserving fdt memory region: addr=8300000 size=a8000
   Using Device Tree in place at 0000000008300000, end 00000000083aafff
## reserved-memory:
  cma: addr=10000000 size=10000000
  ramoops@110000: addr=110000 size=e0000
Adding bank: 0x00200000 - 0xf0000000 (size: 0xefe00000)
Adding bank: 0x100000000 - 0x200000000 (size: 0x100000000)
Adding bank: 0x2f0000000 - 0x300000000 (size: 0x10000000)
Total: 4442.471/4744.603 ms

Starting kernel ...

[    4.747750] Booting Linux on physical CPU 0x0000000000 [0x412fd050]
[    4.747777] Linux version 6.1.99-vendor-rk35xx (build@armbian) (aarch64-linux-gnu-gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0, GNU ld (GNU Binutils for Ubuntu) 2.38) #1 SMP Wed Feb 12 08:55:33 UTC 2025
[    4.754890] Machine model: Mekotronics R58X-4G (RK3588 EDGE LP4x V1.2 BlueBerry Board)

(ends up with per-boot random MAC addresses)

With v2024.03:

U-Boot 2017.09-armbian (Mar 18 2025 - 19:28:56 +0000)

Model: Mekotronics R58X-4G (RK3588 EDGE LP4x V1.2 BlueBerry Board)
MPIDR: 0x81000000
PreSerial: 2, raw, 0xfeb50000
DRAM:  8 GiB
Sysmem: init
Relocation Offset: eda1a000
Relocation fdt: eb9f8ef0 - eb9fecc0
CR: M/C/I
Using default environment

DM: v2
mmc@fe2c0000: 1, mmc@fe2e0000: 0
Bootdev(atags): mmc 0
MMC0: HS400 Enhanced Strobe, 200Mhz
PartType: EFI
No misc partition
boot mode: normal
FIT: No boot partition
Failed to load DTB, ret=-2
No valid DTB, ret=-22
Failed to get kernel dtb, ret=-22
Model: Mekotronics R58X-4G (RK3588 EDGE LP4x V1.2 BlueBerry Board)
MPIDR: 0x81000000
rockchip_set_serialno: starting serial number code
rockchip_set_ethaddr: starting ethernet MAC set
rockchip_set_ethaddr: serial# for eth base is 396c46e7b45f06f1
rockchip_set_ethaddr: checksumming serial digit 0
rockchip_set_ethaddr: checksumming serial digit 1
rockchip_set_ethaddr: checksumming serial digit 2
rockchip_set_ethaddr: checksumming serial digit 3
rockchip_set_ethaddr: checksumming serial digit 4
rockchip_set_ethaddr: checksumming serial digit 5
rockchip_set_ethaddr: checksumming serial digit 6
rockchip_set_ethaddr: checksumming serial digit 7
rockchip_set_ethaddr: checksumming serial digit 8
rockchip_set_ethaddr: checksumming serial digit 9
rockchip_set_ethaddr: checksumming serial digit 10
rockchip_set_ethaddr: checksumming serial digit 11
rockchip_set_ethaddr: checksumming serial digit 12
rockchip_set_ethaddr: checksumming serial digit 13
rockchip_set_ethaddr: checksumming serial digit 14
rockchip_set_ethaddr: checksumming serial digit 15
rockchip_set_ethaddr: going for vendor_storage_read
rockchip_set_ethaddr: vendor_storage_read returned 12
rockchip_set_ethaddr: looping... 0 and ret 12
rockchip_set_ethaddr: setting in env
rockchip_set_ethaddr: looping... 1 and ret 12
rockchip_set_ethaddr: setting in env
setup_download_mode checking if download is NOT HOTkey pressed...
CLK: (sync kernel. arm: enter 1008000 KHz, init 1008000 KHz, kernel 0N/A)
  b0pll 24000 KHz
  b1pll 24000 KHz
  lpll 24000 KHz
  v0pll 24000 KHz
  aupll 24000 KHz
  cpll 1500000 KHz
  gpll 1188000 KHz
  npll 24000 KHz
  ppll 1100000 KHz
  aclk_center_root 702000 KHz
  pclk_center_root 100000 KHz
  hclk_center_root 396000 KHz
  aclk_center_low_root 500000 KHz
  aclk_top_root 750000 KHz
  pclk_top_root 100000 KHz
  aclk_low_top_root 396000 KHz
Net:   No ethernet found.
Hit key to stop autoboot('CTRL+C'):  0
starting USB...
Bus usb@fcd00000: Register 2000140 NbrPorts 2
Starting the controller
USB XHCI 1.10
scanning bus usb@fcd00000 for devices... 1 USB Device(s) found
       scanning usb for storage devices... 0 Storage Device(s) found

Device 0: unknown device
MMC: no card present
mmc_init: -123, time 1
pcie@fe150000: PCIe Linking... LTSSM is 0x1
pcie@fe150000: PCIe Linking... LTSSM is 0x210022
pcie@fe150000: PCIe Linking... LTSSM is 0x210022
pcie@fe150000: PCIe Linking... LTSSM is 0x210023
pcie@fe150000: PCIe Link up, LTSSM is 0x230011
pcie@fe150000: PCIE-0: Link up (Gen3-x4, Bus0)
pcie@fe150000: invalid flags type!

Device 0: Vendor: 0x15b7 Rev: 281010WD Prod: 23285G403448
            Type: Hard Disk
            Capacity: 953869.7 MB = 931.5 GB (1953525168 x 512)
... is now current device
Scanning nvme 0:1...
Found U-Boot script /boot/boot.scr
4149 bytes read in 3 ms (1.3 MiB/s)
## Executing script at 00500000
Boot script loaded from nvme 0:1
177 bytes read in 2 ms (85.9 KiB/s)
14619961 bytes read in 16 ms (871.4 MiB/s)
48554496 bytes read in 48 ms (964.7 MiB/s)
272881 bytes read in 21 ms (12.4 MiB/s)
Trying kaslrseed command... Info: Unknown command can be safely ignored since kaslrseed does not apply to all boards.
Unknown command 'kaslrseed' - try 'help'
Fdt Ramdisk skip relocation
No misc partition
## Loading init Ramdisk from Legacy Image at 0a200000 ...
   Image Name:   uInitrd
   Image Type:   AArch64 Linux RAMDisk Image (gzip compressed)
   Data Size:    14619897 Bytes = 13.9 MiB
   Load Address: 00000000
   Entry Point:  00000000
   Verifying Checksum ... OK
## Flattened Device Tree blob at 0x08300000
   Booting using the fdt blob at 0x08300000
   reserving fdt memory region: addr=8300000 size=a8000
   Using Device Tree in place at 0000000008300000, end 00000000083aafff
WARNING: could not set reg FDT_ERR_BADOFFSET.
## reserved-memory:
  cma: addr=10000000 size=10000000
  ramoops@110000: addr=110000 size=e0000
Adding bank: 0x00200000 - 0xf0000000 (size: 0xefe00000)
Adding bank: 0x100000000 - 0x200000000 (size: 0x100000000)
Adding bank: 0x2f0000000 - 0x300000000 (size: 0x10000000)
Total: 4378.552/4412.333 ms

Starting kernel ...

[    4.415496] Booting Linux on physical CPU 0x0000000000 [0x412fd050]
[    4.415522] Linux version 6.1.99-vendor-rk35xx (build@armbian) (aarch64-linux-gnu-gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0, GNU ld (GNU Binutils for Ubuntu) 2.38) #1 SMP Sun Mar  9 02:59:50 UTC 2025
[    4.422641] Machine model: Mekotronics R58X-4G (RK3588 EDGE LP4x V1.2 BlueBerry Board)

(stable MAC addresses as before)

@rpardini rpardini marked this pull request as ready for review March 18, 2025 22:15
@rpardini rpardini requested a review from igorpecovnik as a code owner March 18, 2025 22:15
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 05 Milestone: Second quarter release and removed Needs review Seeking for review labels Mar 19, 2025
@igorpecovnik igorpecovnik merged commit e9708b8 into armbian:main Mar 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

Assignees
No one assigned
Labels
05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpardini @igorpecovnik