This repository was archived by the owner on Feb 24, 2021. It is now read-only.
Configuration: improve plugin management #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelcarmena
force-pushed
the
reorg-gradle-conf
branch
from
31dc38b to
1021538
Compare
rachelcarmena
force-pushed
the
reorg-gradle-conf
branch
from
1021538 to
520a746
Compare
aballano
reviewed
Aug 24, 2020
| disabled_rules=import-ordering,no-unit-return,curly-spacing |
There was a problem hiding this comment.
was this added on purpose? AFAIK ktlint shouldn't affect non-kotlin files
There was a problem hiding this comment.
Righ, thanks for the review!! When re-organizing the configuration, the ktlint version was considered and a lot of errors raised with functions following this format:
<signature> =
{ ... }
I updated this configuration for all the repositories except arrow-check (I'll create an issue afterwards).
aballano
approved these changes
Aug 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.