Specify type variance for compose and plus methods across the lenses
#2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These all must be specified, otherwise the compiler is unable to determine which function to call when there are multiple (e.g. when using `Getter compose Getter` to create a `Getter` instead of a `Fold`).
magneticflux-
force-pushed
the
composition-type-variance
branch
from
df8d61d to
8186051
Compare
|
I was able to build the documentation on my own machine and nothing in the docs was changed by this PR, so this seems like a spurious failure. |
|
There seems to be something randomly failing after bumping to Kotlin 1.5.10 at the start-up of the documentation checking tools. Re-running the CI task seems to work... |
nomisRev
approved these changes
Jun 6, 2021
pakoito
approved these changes
Jun 8, 2021
|
Thanks & congrats for your first contribution @magneticflux- 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These all must be specified, otherwise the compiler is unable to determine which function to call when there are multiple (e.g. when using
Getter compose Getterto create aGetterinstead of aFold).Closes #2414