Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support generics and inner classes in @optics #2776

Merged
merged 3 commits into from
Aug 3, 2022
+275 −61
Merged

Support generics and inner classes in @optics #2776

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1aa6163
Support generics and inner classes in `@optics`
serras Jul 28, 2022
f6e67ad
Remove the check for generics in OpticsProcessor
serras Aug 2, 2022
e510360
Merge branch 'main' into optics-ksp-generics-inner
i-walker Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove the check for generics in OpticsProcessor
@serras
serras authored Aug 2, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit f6e67ad5486ae53ff3c93bf0606ccfdef81c5f06
6 changes: 0 additions & 6 deletions ...ibs/optics/arrow-optics-ksp-plugin/src/main/kotlin/arrow/optics/plugin/OpticsProcessor.kt
View file
Original file line number Diff line number Diff line change
@@ -38,12 +38,6 @@ class OpticsProcessor(private val codegen: CodeGenerator, private val logger: KS
return
}

// check that it does not have type arguments
/* if (klass.typeParameters.isNotEmpty()) {
logger.error(klass.qualifiedNameOrSimpleName.typeParametersErrorMessage, klass)
return
} */

// check that the companion object exists
if (klass.companionObject == null) {
logger.error(klass.qualifiedNameOrSimpleName.noCompanion, klass)