Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exist fun to Either, for migration from Validated #2941

Merged
merged 6 commits into from
Mar 2, 2023
Merged

Add exist fun to Either, for migration from Validated #2941

merged 6 commits into from
Mar 2, 2023

Conversation

Zordid
Copy link
Contributor

@Zordid Zordid commented Feb 22, 2023

Fixes #2938 by introducing a deprecated new exist fun for Either, just to allow migration coming from Validated which had this method instead of the exists in Option and Either.

@nomisRev
Copy link
Member

nomisRev commented Feb 22, 2023 •
edited
Loading

This is missing a ./gradlew apiDump commit.

nomisRev
nomisRev approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Zordid! And thank you for test driving the migrations, and alpha versions 🙌

@nomisRev nomisRev requested a review from a team March 2, 2023 08:47
@nomisRev nomisRev merged commit 38f9d67 into arrow-kt:main Mar 2, 2023
@Zordid Zordid deleted the create_either_exist_for_migration branch March 13, 2023 11:13
@Zordid Zordid restored the create_either_exist_for_migration branch March 13, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serras serras serras approved these changes

@nomisRev nomisRev nomisRev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated fun exists in Either was named exist in Validated which makes migration harder
3 participants
@Zordid @nomisRev @serras