FixIor deprecation replacement expressions
#2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gutiory
force-pushed
the
jg-fix-ior-deprecations
branch
from
cf80546 to
5ddd70f
Compare
Kover Report
|
gutiory
requested review from
serras,
nomisRev and
franciscodr
and removed request for
serras
serras
approved these changes
Mar 24, 2023
franciscodr
approved these changes
Mar 24, 2023
| ) | ||
| public fun <A, B, C> Ior<A, B>.zip(SA: Semigroup<A>, fb: Ior<A, C>): Ior<A, Pair<B, C>> = | ||
| ior(SA::combine) { Pair(this@zip.bind(), fb.bind()) } | ||
|
|
||
| @Deprecated( | ||
| NicheAPI + "Prefer using the inline ior DSL", | ||
| ReplaceWith("ior(SA::combine) { map(this@zip.bind(), c.bind()) }", "arrow.core.raise.ior", "arrow.typeclasses.combine") | ||
| ReplaceWith("ior({a, b -> a + b}) { map(this.bind(), c.bind()) }", "arrow.core.raise.ior") |
There was a problem hiding this comment.
I think @serras has asked this in another PR, but being A a generic type, this code won't compile unless we run it under the scope of a Semigroup instance, will it?
Additionally, why do you use the SA::combine function in this ReplaceWith expression and use the plus operator in the rest of zip alternatives?
There was a problem hiding this comment.
This was actually a bug 😅 . Good catch, @franciscodr !. See 133847c (#2976)
| NicheAPI + "Prefer when or fold instead", | ||
| ReplaceWith(" MN.run { fold({ f(it) },{ g(it) },{ a,b -> f(a).combine(g(b)) })}") | ||
| ) | ||
| @Deprecated(NicheAPI + "Prefer when or fold instead. See the Arrow web migration guide for more info.") |
There was a problem hiding this comment.
Have we created a task for adding these changes to the migration guide?
There was a problem hiding this comment.
I've just created it 😄 . Thanks for the suggestion, @franciscodr!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some of the deprecation
ReplaceWithsuggestions forIorlisted in #2964. I'll update the issue table once this is merged.And for those replacements that are no working, a section will be created in Arrow website, explaining the best way to migrate these methods.