-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arrow-core: speedup 'Arb.string()' related slow tests #3005
Conversation
Arb.string() seems to be slow on iosX64, try to use Arb.unit() as we don't really care about the type here
Wow that is an amazing improvements 😍 Thank you for digging into this @abendt! A bit related, but also unrelated to this. I am a bit curious if running the tests on latest JDK would increase build times as well. IIRC only building the binaries in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome @abendt. Just two small nits (probably missing proper imports, so suggestions is going to break).
arrow-libs/core/arrow-core/src/commonTest/kotlin/arrow/core/continuations/IorSpec.kt
Outdated
Show resolved
Hide resolved
arrow-libs/core/arrow-core/src/commonTest/kotlin/arrow/core/raise/IorSpec.kt
Outdated
Show resolved
Hide resolved
Sure, that could prohably improve build times. More ideas:
|
We actually are working on improving that in #2988, although we may fix it once and for all in the Gradle plug-in we use arrow-kt/arrow-gradle-config#69 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping us improve the build times, @abendt I appreciate the time you're putting on this!
Some of the tests in arrow-core run slow on the non jvm platforms (#2908)
One reason seems to be the use of
Arb.string()
especially when used inside arbs that generate collections (map, list, nonemptylist)See
This MR replaces
Arb.string()
withArb.int()
in some tests to speed up the execution time