Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix finalizer order for resourceScope to match autoCloseScope #3430

Merged
merged 1 commit into from
May 18, 2024
Merged

Fix finalizer order for resourceScope to match autoCloseScope #3430

merged 1 commit into from
May 18, 2024

Conversation

kyay10
Copy link
Collaborator

@kyay10 kyay10 commented May 17, 2024

The test here is the same one added in #3387

@kyay10 kyay10 requested review from serras and nomisRev May 17, 2024 21:31
@github-actions GitHub Actions
Copy link
Contributor

Kover Report

File Coverage [70.89%]
arrow-libs/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/Resource.kt 70.89%
Total Project Coverage 61.01%

nomisRev
nomisRev approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, what, how!? I thought we had tests for this. I guess something weird happened in between 1.x.x and 2.x.x, I guess some regression :/
Thank you for catching it @kyay10, and cleaning up the redundant try/catch.

@nomisRev nomisRev merged commit 7077846 into main May 18, 2024
11 checks passed
@nomisRev nomisRev deleted the kyay10/resourceScope-autoClose-order branch May 18, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomisRev nomisRev nomisRev approved these changes

@serras serras Awaiting requested review from serras

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyay10 @nomisRev