Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit autoupdate #1281

Merged
merged 2 commits into from
Dec 21, 2022
Merged

[pre-commit.ci] pre-commit autoupdate #1281

merged 2 commits into from
Dec 21, 2022

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Dec 20, 2022

@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
0839d5f 
updates:
- [github.com/charliermarsh/ruff-pre-commit: v0.0.177 → v0.0.188](astral-sh/ruff-pre-commit@v0.0.177...v0.0.188)
- [github.com/pycqa/isort: 5.11.1 → v5.11.3](PyCQA/isort@5.11.1...v5.11.3)
@pre-commit-ci pre-commit-ci bot requested a review from a team as a code owner December 20, 2022 02:17
@WilliamJamieson
Copy link
Contributor

This should not be merged

WilliamJamieson
WilliamJamieson suggested changes Dec 20, 2022
View reviewed changes
@braingram braingram force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 5fecef8 to d50dc05 Compare December 20, 2022 16:51
@WilliamJamieson
Copy link
Contributor

The ruff pin should move. The exclude in pre-commit needs to be updated in addition to the conf.py.

@WilliamJamieson
Copy link
Contributor

I'll fix this tonight or tomorrow.

@WilliamJamieson WilliamJamieson force-pushed the pre-commit-ci-update-config branch from d50dc05 to 805afba Compare December 21, 2022 15:18
@WilliamJamieson
Copy link
Contributor

I just updated this to use the --force-exclude option that was added in astral-sh/ruff#1295 and released in version 0.0.189 of ruff. This allows us to apply the exclude included in the config directly in the pre-commit config without the need for duplication.

@braingram
Copy link
Contributor

Thanks for updating this.

@WilliamJamieson
Copy link
Contributor

Thanks for updating this.

I figured I should, since I specifically requested that ruff add the --force-exclude option. So it is very new

@WilliamJamieson WilliamJamieson self-requested a review December 21, 2022 15:43
@WilliamJamieson WilliamJamieson merged commit ea4f92b into master Dec 21, 2022
@WilliamJamieson WilliamJamieson deleted the pre-commit-ci-update-config branch December 21, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braingram braingram braingram approved these changes

@WilliamJamieson WilliamJamieson WilliamJamieson approved these changes

Assignees
No one assigned
Labels
no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilliamJamieson @braingram