Code

Preliminary cleanup pass#339

Code

Merged

MaikKlein merged 29 commits intoash-rs:masterash-rs/ash:masterfrom Traverse-Research:cleanupTraverse-Research/ash:cleanupCopy head branch name to clipboardDec 12, 2020

Commits

Commits on Nov 24, 2020

• Fix clippy::manual_strip

  MarijnS95

  committed
  3011d24

  Copy full SHA for 3011d24

• Fix clippy::comparison_to_empty

  MarijnS95

  committed
  d035f82

  Copy full SHA for d035f82

• Fix clippy::needless_lifetimes

  MarijnS95

  committed
  f7c9451

  Copy full SHA for f7c9451

• generator: Drop unnecessary edgecase for charptr array in builder

  MarijnS95

  committed
  f078547

  Copy full SHA for f078547

• generator: Make array type handling more linear

  MarijnS95

  committed
  abd3052

  Copy full SHA for abd3052

• prelude: Provide Result -> VkResult<()> conversion

  MarijnS95

  committed
  8803570

  Copy full SHA for 8803570

• Add #[must_use] to Result type

  MarijnS95

  committed
  6110c23

  Copy full SHA for 6110c23

• Fix all unchecked vk::Result cases

  MarijnS95

  committed
  7e2e938

  Copy full SHA for 7e2e938

• generator: Fix typos

  MarijnS95

  committed
  5a98daa

  Copy full SHA for 5a98daa

• generator: Assert char ptrs have "null-terminated" len attribute

  MarijnS95

  committed
  f0f012d

  Copy full SHA for f0f012d

• prelude: Provide result_with_success helper for Result -> VKresult

  MarijnS95

  committed
  e8305d4

  Copy full SHA for e8305d4

• Cleanup match{success} blocks with SSR

  Show description for 62961b4
  MarijnS95

  committed
  62961b4

  Copy full SHA for 62961b4

• Simplify matching on Result::SUCCESS

  Show description for d619ecb
  MarijnS95

  committed
  d619ecb

  Copy full SHA for d619ecb

• Simplify intermediate error return

  Show description for e3f9aaa
  MarijnS95

  committed
  e3f9aaa

  Copy full SHA for e3f9aaa

• Simplify error checking with .result()? and .result_with_success()

  MarijnS95

  committed
  e23e496

  Copy full SHA for e23e496

• generator: Ignore empty basetype in typedef (forward declaration)

  Show description for d64286e
  MarijnS95

  committed
  d64286e

  Copy full SHA for d64286e

• Suggestion: Allocate data in get_ray_tracing_shader_group_handles

  MarijnS95

  committed
  7e1a601

  Copy full SHA for 7e1a601

• generator: Update nom to 6.0

  MarijnS95

  committed
  05dcdbf

  Copy full SHA for 05dcdbf

• generator: Generalize C expression conversion to TokenStream

  MarijnS95

  committed
  79be32d

  Copy full SHA for 79be32d

• generator: Simplify ReferenceType::to_tokens with quote!

  MarijnS95

  committed
  76a19df

  Copy full SHA for 76a19df

• generator: Refactor to not parse our own stringified token stream

  MarijnS95

  committed
  17f3010

  Copy full SHA for 17f3010

• generator: Deal with pointers to static-sized arrays

  MarijnS95

  committed
  392f943

  Copy full SHA for 392f943

• generator: Apply static-sized array pointer to size containing *

  MarijnS95

  committed
  f4adefc

  Copy full SHA for f4adefc

• generator: setter: Interpret all references as ptr, not just p_/pp_

  MarijnS95

  committed
  18fce5b

  Copy full SHA for 18fce5b

• generator: quote::* is already imported

  MarijnS95

  committed
  6d04568

  Copy full SHA for 6d04568

• generator: Replace manual fn to_tokens with quote::ToTokens trait impl

  MarijnS95

  committed
  162c861

  Copy full SHA for 162c861

• generator: Return str reference from constant_name

  MarijnS95

  committed
  d366983

  Copy full SHA for d366983

Commits on Dec 6, 2020

• generator: Replace unused to_type_tokens with name_to_tokens

  Show description for a83882f
  MarijnS95

  committed
  a83882f

  Copy full SHA for a83882f

Commits on Dec 11, 2020

• generator: setters: Use safe mutable references instead of raw ptrs

  MarijnS95

  committed
  5ae5c17

  Copy full SHA for 5ae5c17