-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Vulkan-Headers to 1.3.206 #563
Conversation
a76b021
to
f43a5c2
Compare
Can't update to 1.3.205 either, |
Seems to have been fixed in KhronosGroup/Vulkan-Docs#1764. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it wasn't clear, I think this is a breaking change, because e.g. Extends*
for structs that were made core have been renamed.
@Ralith Do we think that's a problem, or an I'm thinking about getting a patch release out now then, and release a breaking release with Vulkan 1.3 and the rest shortly after. It's a large update that "deserves some attention" anyway. |
It's definitely a technical semver break, since it is legal (regardless of unsafe) for downstream code to reference the changed identifiers. I think the real-world impact is probably low, but I also don't see a need to play fast and loose with semver. |
Should have probably not mentioned I don't want to go figure out how to add a bunch of |
Yeah, I don't think that's worth the trouble; this only comes up on Vulkan minor version bumps anyway. |
Vulkan 1.3 is out, with many extensions stabilized. This'll have to remain draft until the next spec version (hopefully next week) where (again, hopefully) KhronosGroup/Vulkan-Docs#1746 is incorporated - otherwise we'll have to work around in our generator :(