Updated: raw-window-handle & winit #838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No comment @MarijnS95? |
|
See #799. |
Thanks, I misunderstood and thought that PR only updated |
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not my finest work.
This pull request updates the following dependencies:
raw-window-handle = "0.6"
winit = "0.29.4"
I'm aware of a pull request to update raw-window-handle to 0.6, (after I was done with this pull request >_>)
This pull request also updates the latest Winit version.
I ran and tested the code on Linux KDE Wayland, on exit it outputs "zwp_linux_dmabuf_v1@38 still attached".
This is a improvement over the dozen Wayland warnings it gives using the current git master Winit version.
Please validate for correctness.