Outline monomorphic load functions #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
approved these changes
Mar 30, 2024
There was a problem hiding this comment.
Sounds like a simple but solid improvement! Now that the expensive monomorphization around XXXFnXXX::load() is gone, there should be no need to apply the same trick to the new load_with() function introduced in #846 I presume.
Co-authored-by: Marijn Suijten <marijns95@gmail.com>
Ralith
force-pushed
the
outlined-loaders
branch
from
40bdcc3 to
ba78cf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to save about 5MiB (out of 77MiB total pre-change) in the debug build of ash-window's winit example. No obvious impact on compile time or release build size, probably because these only have one callsite each anyway in normal use. Still, seems like an easy win, might have more impact to folks who use
*Fndirectly, and it's nice to know we're not emitting a bunch of unnecessary IR.No changelog entry as this is not a publicly-visible change.