Mango support #664
Draft
Mango support #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… - code documentation
Mango annotations
which make some trouble
to make the distinction between column reference and literals
x_path_startwith works recursively
…a VODMK parsing - move constants to the glossary
the model structure
…removed, shouln't be committed - documentation
add_epoch_position()
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
==========================================
+ Coverage 82.97% 83.70% +0.72%
==========================================
Files 75 80 +5
Lines 7759 8272 +513
==========================================
+ Hits 6438 6924 +486
- Misses 1321 1348 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The failing CI task is due to ongoing change in the Vizier implementation. This will be fixed later. |
implementation, which could change again.
implementation, which could change again. Style check
mango-support # Conflicts: # pyvo/mivot/tests/test_mivot_instance_generation.py # pyvo/mivot/tests/test_user_api.py
implementation, which could change again. Style check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR proposes an API that facilitates the mapping of VOTable data to the MANGO data model.
Mango is a model (VO working draft) designed to extend the description of table data in such a way that each table row can be interpreted as a Mango object (
MangoObjectclass of the Mango data model-.MangoObjectinstances consist of a property container, a description of the data origin, and links to other Mango objects (not yet implemented).In this current implementation, only a few properties are supported (EpochPosition and Photometry), and the data origin can be added as literal values (not associated with table data).
To annotate data, the user must provide mapping dictionaries that associate model roles with column identifiers or literal values from which the code builds complete MIVOT annotations.
Complete examples can be found in
pyvo/mivot/tests/test_mango_annoter.pyandpyvo/mivot/tests/test_header_mapper.py.The
HeaderMapperclass can help with this process. It analyzesINFO,COOSYS,TIMESYS, andFIELDSto suggest mappings that matches the current VOTable metadata.