Support of some NBCs and better error handling #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work needed before making a PR to upstream: - Write `register_*` functions for NBS; - Rework error handling to factor code out and do everything in `register_mpi_call`'s API.
- Custom error type `InterpolError` and `InterpolErrorKind`, with automatic type conversion using the `From` trait for cleaner outputs and idiomatic error handling. Also implemented the `impl_builder_error` macro to easily implement the `From` trait on each `Mpi*BuilderError` type; - Implemented the `impl_register` macro to reduce the amount of boilerplate code; - Completed dispatch of MPI calls intercepted from **interpol-c**; - Separated serialization role from `register_finalize` for more flexible usage. It will make possible to serialize the contents of the static vector at any point in the program, e.g. when an error occurs; - Implemented helper FFI function that allows to deserialize all traces, sort them and reserialize into a single file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the following Non-Blocking Collectives (NBCs) and closes #1:
MPI_Ibcast;MPI_Igather;MPI_Ireduce;MPI_Iscatter.Support for other NBCs is planned (
MPI_Iall*andMPI_I*vvariants) but is not implemented yet.Support for automatic merging and parallel sorting of the traces has also been added, along with a complete rewrite of the error handling for a more idiomatic implementation and a cleaner output.