Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix demo and Helper #33

Closed
wants to merge 22 commits into from
Closed

fix demo and Helper #33

wants to merge 22 commits into from

Conversation

DarkSide666
Copy link
Member

@DarkSide666 DarkSide666 commented Mar 31, 2023 •
edited by mvorisek
Loading

  • adds cleanupDrafts method in File data model
  • fixes linked status implementation
  • delete filesystem file only after we actually delete file record in DB. That's important for safety to not break data integrity in case DB statement fails for some reason. It's not that bad if we have orphaned filesystem file, but having orphaned DB record is not acceptable.
  • fix and improve demo

@DarkSide666 DarkSide666 marked this pull request as draft March 31, 2023 15:19
@DarkSide666 DarkSide666 marked this pull request as ready for review March 31, 2023 15:22
@DarkSide666 DarkSide666 requested a review from mvorisek March 31, 2023 15:22
mvorisek
mvorisek reviewed Mar 31, 2023
View reviewed changes
@DarkSide666 DarkSide666 requested a review from mvorisek April 3, 2023 10:17
@abbadon1334 abbadon1334 mentioned this pull request Apr 4, 2023
Merged
@DarkSide666 DarkSide666 marked this pull request as draft April 4, 2023 08:05
DarkSide666
DarkSide666 commented Apr 5, 2023
View reviewed changes
mvorisek
mvorisek reviewed Apr 8, 2023
View reviewed changes
mvorisek
mvorisek reviewed Apr 10, 2023
View reviewed changes
@DarkSide666 DarkSide666 requested a review from mvorisek April 11, 2023 14:46
@DarkSide666 DarkSide666 marked this pull request as ready for review April 12, 2023 05:17
@DarkSide666 DarkSide666 marked this pull request as draft April 16, 2023 13:39
@DarkSide666
Copy link
Member Author

This was split in multiple other PRs, so closing this one

@DarkSide666 DarkSide666 deleted the feature/fix-demo branch April 16, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvorisek mvorisek Awaiting requested review from mvorisek

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkSide666 @mvorisek @vorismi3