Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PHPStan to level 5 #1581

Merged
merged 8 commits into from
Dec 27, 2020
Merged

Improve PHPStan to level 5 #1581

merged 8 commits into from
Dec 27, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Dec 26, 2020

ignores were generated by:

$d = json_decode(<<<'EOT'
<<< output from vendor/bin/phpstan analyse --error-format=json
EOT, true)['files'];

foreach ($d as $f => $vs) {
    $messagesUnique = [];
    foreach ($vs['messages'] as ['message' => $m]) {
        $messagesUnique[$m] = true;
    }
    $messagesUnique = array_keys($messagesUnique);
    
    foreach ($messagesUnique as $m) {
        echo '        -' . "\n"
            . '            path: \'' . preg_replace('~^/__w/ui/ui/~', '', $f) . '\'' . "\n"
            . '            message: \'~^' . preg_replace('~\'~', '\'\'', preg_replace('~\\\\:~', ':', preg_quote($m, '~'))) . '$~\'' . "\n";
    }
}

@mvorisek mvorisek force-pushed the phpstan_l3 branch 12 times, most recently from 5a3601f to 12beec2 Compare December 26, 2020 22:46
@mvorisek mvorisek marked this pull request as ready for review December 26, 2020 22:53
@mvorisek mvorisek changed the title Improve PHPStan level to 3 Improve PHPStan level to 5 Dec 27, 2020
@mvorisek mvorisek changed the title Improve PHPStan level to 5 Improve PHPStan to level 5 Dec 27, 2020
@mvorisek mvorisek added the RTM label Dec 27, 2020
@mvorisek mvorisek merged commit b7c9305 into develop Dec 27, 2020
@mvorisek mvorisek deleted the phpstan_l3 branch December 27, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants