Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream master #182

Merged
merged 32 commits into from
Sep 23, 2020
Merged

Upstream master #182

merged 32 commits into from
Sep 23, 2020

Conversation

aminya
Copy link
Member

@aminya aminya commented Sep 23, 2020

Upstream master

aminya and others added 30 commits September 17, 2020 18:46
Don't call the callback on retry
don't finalize until the end which the test fails or passes.
…-4upstream

Tests: retry timed out steps automatically
This dependancy is not being utilized in the atom repo currently

It was used in https://github.com/atom/atom/blob/72b120cfe12d987407c9745ec0a4c55a6c83104c/spec/random-editor-spec.coffee
but that spec has long been deleted from the repo
Reason for change: This test has been flaky on our CI due to its async
nature.

The expectation is for .build to construct TextEditor with the right
params.

We don't have to load the correct language package for this test. We can
load a dummy languageMode and assert that the correct grammar is set on
TextEditor
Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.1 to 5.7.4.
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](acornjs/acorn@5.7.1...5.7.4)

Signed-off-by: dependabot[bot] <support@github.com>
@aminya aminya merged commit c382493 into master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants