Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel tests #50

Merged
merged 14 commits into from
Jul 18, 2020
Merged

Parallel tests #50

merged 14 commits into from
Jul 18, 2020

Conversation

aminya
Copy link
Member

@aminya aminya commented Jul 18, 2020

No description provided.

@aminya aminya merged commit ddc5a4b into bump_electron_6 Jul 18, 2020
@DeeDeeG
Copy link
Member

DeeDeeG commented Jul 18, 2020

Hmm. I'm not sure merging unrelated PRs into one-another through the GitHub UI like this is a good idea. Now the PR is closed and can't be re-opened.

By merging this into bump_electron_6 you tie these changes from this PR to the fate of that experiment.

For the sake of collaboration and review, I would encourage you to merge on the command-line if you want to see two sets of changes combined. And that they nonetheless should be merged into master one at a time, if possible.

Separation of concerns makes a maintainer's life easier and preserves one's sanity. It is also polite toward any reviewer to not change the state of proposed PRs this drastically. It is early days for the fork, but setting up good habits early can pay off; by making them habitual, they become second-nature and you don't have to think about it anymore.

Anyway, that's all subjective project maintenance philosophy. My two cents.

@aminya aminya changed the title Windows tests Parallel tests Jul 18, 2020
@aminya
Copy link
Member Author

aminya commented Jul 18, 2020

We are not going to merge #48 to our master. That is just an experiment. I merged this to that one to save time.

@DeeDeeG
Copy link
Member

DeeDeeG commented Jul 18, 2020

They are both your branches, so... I can't say I'm not confused, but I trust that you know what you're doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting up Azure pipelines
2 participants