Failed to activate the tree-view package

[scamII]

[Enter steps to reproduce below:]

1. ...
2. ...

Atom Version: 0.189.0
System: linux 3.16.0-33-generic
Thrown From: one-light-ui package, v0.4.0

Stack Trace

Failed to activate the tree-view package

At variable @syntax-background-color is undefined in /usr/share/atom/resources/app/node_modules/one-light-ui/styles/ui-variables.less:14:13

LessError: variable @syntax-background-color is undefined
  at /usr/share/atom/resources/app/node_modules/one-light-ui/styles/ui-variables.less:14:13

Commands

Config

{
  "core": {
    "themes": [
      "one-light-ui",
      "tomorrow-night-blue-syntax"
    ]
  }
}

Installed Packages

# User
color-picker, v1.6.0
emmet, v2.3.6
symfony-snippets, v0.3.0
tomorrow-night-blue-syntax, v0.1.0
wordpress, v0.2.0
wordpress-api, v1.2.0

# Dev
No dev packages

[izuzak]

This seems to be happening because you're using the one-light-ui theme with the tomorrow-night-blue-syntax syntax theme. The tomorrow-night-blue-syntax theme doesn't define syntax-background-color and one-light-ui is trying to use it.

@simurai Any thoughts on this? If the syntax-background-color variable isn't defined, should the UI theme handle that somehow or should we tell the user to open an issue on the syntax theme they're using?

[simurai]

If the syntax-background-color variable isn't defined, should the UI theme handle that somehow or should we tell the user to open an issue on the syntax theme they're using?

There is now a "guard" found here. If the variable doesn't exist, it just uses the default from here: https://github.com/atom/atom/blob/master/static/variables/syntax-variables.less#L9 Doesn't always look right, but at least there is no error.

In addition, I think it's still a good idea to raise the issue in the tomorrow-night-blue-syntax theme. But maybe before the docs need to be updated to include also the syntax variables. Then it's more official. I'll look into that.