Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrap domainUrl with new URL().origin #1348

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: wrap domainUrl with new URL().origin #1348

wants to merge 1 commit into from

Conversation

tonyfromundefined
Copy link

Changes

  • We're currently working on an OIDC provider that is compatible with Auth0 SDK, which will allow us to refine the experience for developers to easily integrate with the Auth0 SDK.
  • Where our OIDC provider differs slightly from Auth0 is that it includes a subpath in the domain.
    • There is an issue where the getAccessTokenSilently() API does not work properly in this case.
  • This shouldn't be an issue if it restricted to the Auth0 environment, but it would be semantically correct to wrap the domainUrl in new URL(domainUrl).origin rather than passing it directly in the code, so we're leaving a fix request.

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@tonyfromundefined tonyfromundefined requested a review from a team as a code owner March 14, 2025 10:04
@tonyfromundefined tonyfromundefined changed the title fix: extract origin from domainUrl fix: wrap domainUrl with new URL().origin Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tonyfromundefined