[SDK-2759] Re-scoping cookies and transactions to client ID #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
September 13, 2021 15:55
stevehobbsdev
added
CH: Changed
|
This pull request introduces 1 alert when merging 402cbbc into e0c69fa - view on LGTM.com new alerts:
|
stevehobbsdev
commented
Sep 15, 2021
Comment on lines
+78
to
+83
| await keys | ||
| .filter(key => (clientId ? key.includes(clientId) : true)) | ||
| .reduce(async (memo, key) => { | ||
| await memo; | ||
| await this.cache.remove(key); | ||
| }, Promise.resolve()); |
There was a problem hiding this comment.
Previously these removals were not being awaited properly, this reducer ensures that deletions are happening in sequence.
frederikprijck
previously approved these changes
Sep 15, 2021
frederikprijck
approved these changes
Sep 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes some tweaks to the way cookies are handled with the intention of supporting using multiple instances of the client within the same app. Tweaks have also been made to the cache manager so that only cache items for a particular client ID can be cleared.
Mostly this involves scoping of:
is.authenticatedcookie forcheckSession. This is automatically migrated if the old cookie is found on the systemI've added an E2E test that tries to cover this scenario as well as a new playground page that the tests run against.
References
SDK-2759
Testing
Checklist
master