Add sender field in smtp configs #5056
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louischan-oursky
requested changes
Mar 12, 2025
pkg/lib/translation/service.go
Outdated
| if errors.Is(err, template.ErrNotFound) { | ||
| subject, err = t.RenderText("email.default.subject", variables) | ||
| subject, err = baseTranslations.RenderText("email.default.subject", variables) |
There was a problem hiding this comment.
Please add new tests for this changed behavior.
- Also fixed the bug that graphql api is leaking internal errors
|
Updated, thanks! |
|
I added 3 commits to change the behavior. See if you agree with the changes. |
louischan-oursky
force-pushed
the
dev-2310-2
branch
from
226d361 to
8dc8c76
Compare
louischan-oursky
force-pushed
the
dev-2310-2
branch
from
8dc8c76 to
d2643b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref DEV-2310