Skip to content

Change andThen() to continue false when first validator is false #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

rbygrave
Copy link
Contributor

This is fixing a semantic bug (that has no impact because the validation chain stops anyway) to return false indicating that the validation shouldn't continue.

It has no impact because currently the generated code uses a single chain and that DOES actually stop processing (but then just returns the wrong value).

Tidy this up so that a followup refactor turning this into a lambda is then no behaviour change.

This is fixing a semantic bug (that has no impact because the validation chain stops anyway) to return false indicating that the validation shouldn't continue.

It has no impact because currently the generated code uses a single chain and that DOES actually stop processing (but then just returns the wrong value).

Tidy this up so that a followup refactor turning this into a lambda is then no behaviour change.
@rbygrave rbygrave requested a review from SentryMan January 30, 2025 08:53
@rbygrave rbygrave self-assigned this Jan 30, 2025
@SentryMan SentryMan merged commit c7832b7 into main Jan 30, 2025
7 checks passed
@SentryMan SentryMan deleted the feature/fix-andThen branch January 30, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants