Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip certain error reports in top-level definition analysis #532

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

aviatesk
Copy link
Owner

@aviatesk aviatesk commented Jun 4, 2023

In most cases UncaughtErrorReport or SeriousExceptionReport are the noise when detected in top-level definition analysis, since some methods are intentionally written to throw errors.

In most cases `UncaughtErrorReport` or `SeriousExceptionReport` are
the noise when detected in top-level definition analysis, since some
methods are intentionally written to throw errors.

- fixes #477
- fixes #487
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (83209a6) 89.24% compared to head (b0753db) 89.27%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #532      +/-   ##
==========================================
+ Coverage   89.24%   89.27%   +0.02%     
==========================================
  Files          10       10              
  Lines        3023     3031       +8     
==========================================
+ Hits         2698     2706       +8     
  Misses        325      325              
Impacted Files Coverage Δ
src/analyzers/jetanalyzer.jl 86.58% <100.00%> (+0.07%) ⬆️
src/toplevel/virtualprocess.jl 94.97% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Jun 4, 2023

JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 4 Jun 2023 - 13:17
  • Baseline: 4 Jun 2023 - 13:30
  • Package commits:
  • Target: 88d693
  • Baseline: 83209a
  • Julia commits:
  • Target: f407a4
  • Baseline: f407a4
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["JETAnalyzer{BasicPass} top-level", "self analysis"] 0.94 (5%) ✅ 1.00 (1%)
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 1.07 (5%) ❌ 1.00 (1%)
["JETAnalyzer{SoundPass}", "identity(nothing)"] 0.95 (5%) ✅ 1.00 (1%)
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 0.93 (5%) ✅ 1.00 (1%)
["show(::IO, ::JETCallResult)", "report_opt"] 1.09 (5%) ❌ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Target

Julia Version 1.10.0-DEV.1433
Commit f407a4cac3d (2023-06-04 03:20 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1038-azure #45-Ubuntu SMP Mon Apr 24 15:40:42 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
 speed user nice sys idle irq
 #1 2793 MHz 8166 s 0 s 317 s 2242 s 0 s
 #2 2793 MHz 1964 s 3 s 192 s 8507 s 0 s
 Memory: 6.7812042236328125 GB (4467.03515625 MB free)
 Uptime: 1077.43 sec
 Load Avg: 1.0 1.0 0.73
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, icelake-server)
 Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.10.0-DEV.1433
Commit f407a4cac3d (2023-06-04 03:20 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1038-azure #45-Ubuntu SMP Mon Apr 24 15:40:42 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
 speed user nice sys idle irq
 #1 2793 MHz 13677 s 0 s 478 s 4462 s 0 s
 #2 2793 MHz 4499 s 3 s 275 s 13771 s 0 s
 Memory: 6.7812042236328125 GB (4525.0 MB free)
 Uptime: 1867.31 sec
 Load Avg: 1.0 1.03 0.94
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, icelake-server)
 Threads: 1 on 2 virtual cores

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 4 Jun 2023 - 13:17
  • Package commit: 88d693
  • Julia commit: f407a4
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 216.652 ms (5%) 64.73 KiB (1%) 19
["First-Time-To-JET", "rand(Bool)"] 502.250 ms (5%) 65.14 KiB (1%) 19
["First-Time-To-JET", "sum(\"julia\")"] 210.060 ms (5%) 65.14 KiB (1%) 19
["JETAnalyzer{BasicPass} top-level", "demo"] 54.641 ms (5%) 2.17 MiB (1%) 38106
["JETAnalyzer{BasicPass} top-level", "self analysis"] 11.459 s (5%) 1.190 s 1.26 GiB (1%) 23692271
["JETAnalyzer{BasicPass} top-level", "simple"] 8.590 ms (5%) 1.85 MiB (1%) 32439
["JETAnalyzer{BasicPass}", "identity(nothing)"] 81.700 μs (5%) 7.19 KiB (1%) 102
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 129.030 ms (5%) 33.31 MiB (1%) 625657
["JETAnalyzer{BasicPass}", "rand(Bool)"] 43.080 ms (5%) 12.00 MiB (1%) 220938
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 129.999 μs (5%) 14.77 KiB (1%) 201
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 6.499 ms (5%) 1.71 MiB (1%) 30162
["JETAnalyzer{SoundPass}", "identity(nothing)"] 77.600 μs (5%) 7.19 KiB (1%) 102
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 182.301 ms (5%) 33.771 ms 46.44 MiB (1%) 695885
["JETAnalyzer{SoundPass}", "rand(Bool)"] 43.816 ms (5%) 13.63 MiB (1%) 235310
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 145.099 μs (5%) 18.67 KiB (1%) 238
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 5.983 ms (5%) 1.77 MiB (1%) 31276
["OptAnalyzer", "identity(nothing)"] 128.399 μs (5%) 25.38 KiB (1%) 363
["OptAnalyzer", "println(QuoteNode(nothing))"] 506.010 ms (5%) 60.291 ms 198.99 MiB (1%) 2933848
["OptAnalyzer", "rand(Bool)"] 27.490 ms (5%) 13.66 MiB (1%) 202271
["OptAnalyzer", "sum(\"julia\") (cached)"] 241.099 μs (5%) 57.64 KiB (1%) 790
["OptAnalyzer", "sum(\"julia\")"] 13.334 ms (5%) 5.81 MiB (1%) 86654
["show(::IO, ::JETCallResult)", "report_call"] 4.349 ms (5%) 656.96 KiB (1%) 6893
["show(::IO, ::JETCallResult)", "report_opt"] 22.000 μs (5%) 632 bytes (1%) 14

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.0-DEV.1433
Commit f407a4cac3d (2023-06-04 03:20 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1038-azure #45-Ubuntu SMP Mon Apr 24 15:40:42 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
 speed user nice sys idle irq
 #1 2793 MHz 8166 s 0 s 317 s 2242 s 0 s
 #2 2793 MHz 1964 s 3 s 192 s 8507 s 0 s
 Memory: 6.7812042236328125 GB (4467.03515625 MB free)
 Uptime: 1077.43 sec
 Load Avg: 1.0 1.0 0.73
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, icelake-server)
 Threads: 1 on 2 virtual cores

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 4 Jun 2023 - 13:30
  • Package commit: 83209a
  • Julia commit: f407a4
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 217.477 ms (5%) 64.73 KiB (1%) 19
["First-Time-To-JET", "rand(Bool)"] 506.249 ms (5%) 65.14 KiB (1%) 19
["First-Time-To-JET", "sum(\"julia\")"] 212.107 ms (5%) 65.14 KiB (1%) 19
["JETAnalyzer{BasicPass} top-level", "demo"] 54.910 ms (5%) 2.17 MiB (1%) 38113
["JETAnalyzer{BasicPass} top-level", "self analysis"] 12.142 s (5%) 1.261 s 1.26 GiB (1%) 23689986
["JETAnalyzer{BasicPass} top-level", "simple"] 8.699 ms (5%) 1.86 MiB (1%) 32440
["JETAnalyzer{BasicPass}", "identity(nothing)"] 84.900 μs (5%) 7.19 KiB (1%) 102
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 120.254 ms (5%) 33.31 MiB (1%) 625658
["JETAnalyzer{BasicPass}", "rand(Bool)"] 42.791 ms (5%) 12.00 MiB (1%) 220939
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 131.700 μs (5%) 14.77 KiB (1%) 201
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 6.431 ms (5%) 1.70 MiB (1%) 30161
["JETAnalyzer{SoundPass}", "identity(nothing)"] 81.900 μs (5%) 7.19 KiB (1%) 102
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 183.057 ms (5%) 34.438 ms 46.43 MiB (1%) 695883
["JETAnalyzer{SoundPass}", "rand(Bool)"] 43.886 ms (5%) 13.63 MiB (1%) 235311
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 140.999 μs (5%) 18.67 KiB (1%) 238
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 6.407 ms (5%) 1.77 MiB (1%) 31276
["OptAnalyzer", "identity(nothing)"] 123.400 μs (5%) 25.38 KiB (1%) 363
["OptAnalyzer", "println(QuoteNode(nothing))"] 509.734 ms (5%) 60.610 ms 198.99 MiB (1%) 2933849
["OptAnalyzer", "rand(Bool)"] 27.521 ms (5%) 13.66 MiB (1%) 202272
["OptAnalyzer", "sum(\"julia\") (cached)"] 241.000 μs (5%) 57.64 KiB (1%) 790
["OptAnalyzer", "sum(\"julia\")"] 13.334 ms (5%) 5.81 MiB (1%) 86654
["show(::IO, ::JETCallResult)", "report_call"] 4.325 ms (5%) 656.96 KiB (1%) 6893
["show(::IO, ::JETCallResult)", "report_opt"] 20.100 μs (5%) 632 bytes (1%) 14

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.0-DEV.1433
Commit f407a4cac3d (2023-06-04 03:20 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1038-azure #45-Ubuntu SMP Mon Apr 24 15:40:42 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
 speed user nice sys idle irq
 #1 2793 MHz 13677 s 0 s 478 s 4462 s 0 s
 #2 2793 MHz 4499 s 3 s 275 s 13771 s 0 s
 Memory: 6.7812042236328125 GB (4525.0 MB free)
 Uptime: 1867.31 sec
 Load Avg: 1.0 1.03 0.94
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, icelake-server)
 Threads: 1 on 2 virtual cores

Runtime information

Runtime Info
BLAS #threads 1
BLAS.vendor() lbt
Sys.CPU_THREADS 2

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 46 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 2
On-line CPU(s) list: 0,1
Vendor ID: GenuineIntel
Model name: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
CPU family: 6
Model: 106
Thread(s) per core: 1
Core(s) per socket: 2
Socket(s): 1
Stepping: 6
BogoMIPS: 5586.87
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 96 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 2.5 MiB (2 instances)
L3 cache: 48 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0,1
Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported
Vulnerability L1tf: Mitigation; PTE Inversion
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed: Not affected
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown

Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
Vendor :Intel
Architecture :UnknownIntel
Model Family: 0x06, Model: 0x6a, Stepping: 0x06, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (48, 1280, 49152) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@aviatesk aviatesk merged commit 9cf324a into master Jun 4, 2023
@aviatesk aviatesk deleted the avi/definition-analysis branch June 4, 2023 13:34
Krastanov pushed a commit to QuantumSavory/QuantumSavory.jl that referenced this pull request Sep 11, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Krastanov added a commit to qojulia/QuantumInterface.jl that referenced this pull request Jan 17, 2025
Krastanov added a commit to qojulia/QuantumInterface.jl that referenced this pull request Jan 17, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

false positives with Base.@kwdef False positive: may throw for a function that just want to throw
2 participants