Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support package module usage from inner modules #540

Merged
merged 1 commit into from
Jun 22, 2023
Merged

support package module usage from inner modules #540

merged 1 commit into from
Jun 22, 2023

Conversation

aviatesk
Copy link
Owner

fix #539

@aviatesk aviatesk mentioned this pull request Jun 21, 2023
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (f5eba24) 89.79% compared to head (fde0350) 89.80%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
+ Coverage   89.79%   89.80%   +0.01%     
==========================================
  Files          10       10              
  Lines        3047     3051       +4     
==========================================
+ Hits         2736     2740       +4     
  Misses        311      311
Impacted Files Coverage Δ
src/toplevel/virtualprocess.jl 94.47% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 21 Jun 2023 - 18:30
  • Baseline: 21 Jun 2023 - 18:44
  • Package commits:
  • Target: c3cc0e
  • Baseline: f5eba2
  • Julia commits:
  • Target: 8d0d01
  • Baseline: 8d0d01
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["JETAnalyzer{BasicPass} top-level", "self analysis"] 1.07 (5%) ❌ 1.00 (1%)
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 0.94 (5%) ✅ 1.00 (1%)
["JETAnalyzer{BasicPass}", "rand(Bool)"] 0.93 (5%) ✅ 1.00 (1%)
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 0.81 (5%) ✅ 1.00 (1%)
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 0.89 (5%) ✅ 1.00 (1%)
["JETAnalyzer{SoundPass}", "identity(nothing)"] 0.82 (5%) ✅ 1.00 (1%)
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 0.92 (5%) ✅ 1.00 (1%)
["OptAnalyzer", "identity(nothing)"] 1.07 (5%) ❌ 1.00 (1%)
["OptAnalyzer", "println(QuoteNode(nothing))"] 0.92 (5%) ✅ 1.00 (1%)
["show(::IO, ::JETCallResult)", "report_call"] 0.93 (5%) ✅ 1.00 (1%)
["show(::IO, ::JETCallResult)", "report_opt"] 0.84 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Target

Julia Version 1.10.0-DEV.1541
Commit 8d0d012de54 (2023-06-21 16:13 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1039-azure #46-Ubuntu SMP Mon May 22 15:18:07 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 3355 s 0 s 288 s 7942 s 0 s
 #2 2593 MHz 6943 s 0 s 272 s 4371 s 0 s
 Memory: 6.7812042236328125 GB (4451.71875 MB free)
 Uptime: 1165.63 sec
 Load Avg: 1.0 1.0 0.76
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.10.0-DEV.1541
Commit 8d0d012de54 (2023-06-21 16:13 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1039-azure #46-Ubuntu SMP Mon May 22 15:18:07 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 7818 s 0 s 458 s 11405 s 0 s
 #2 2593 MHz 10729 s 0 s 379 s 8570 s 0 s
 Memory: 6.7812042236328125 GB (4523.1484375 MB free)
 Uptime: 1976.47 sec
 Load Avg: 1.0 1.02 0.94
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 21 Jun 2023 - 18:30
  • Package commit: c3cc0e
  • Julia commit: 8d0d01
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 242.426 ms (5%) 64.73 KiB (1%) 19
["First-Time-To-JET", "rand(Bool)"] 563.599 ms (5%) 65.14 KiB (1%) 19
["First-Time-To-JET", "sum(\"julia\")"] 191.305 ms (5%) 65.14 KiB (1%) 19
["JETAnalyzer{BasicPass} top-level", "demo"] 52.847 ms (5%) 2.26 MiB (1%) 39830
["JETAnalyzer{BasicPass} top-level", "self analysis"] 15.154 s (5%) 1.070 s 1.26 GiB (1%) 23647097
["JETAnalyzer{BasicPass} top-level", "simple"] 8.953 ms (5%) 1.86 MiB (1%) 32710
["JETAnalyzer{BasicPass}", "identity(nothing)"] 99.001 μs (5%) 7.19 KiB (1%) 102
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 153.553 ms (5%) 38.55 MiB (1%) 727340
["JETAnalyzer{BasicPass}", "rand(Bool)"] 43.750 ms (5%) 12.00 MiB (1%) 220928
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 125.102 μs (5%) 14.77 KiB (1%) 201
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 6.212 ms (5%) 1.70 MiB (1%) 30161
["JETAnalyzer{SoundPass}", "identity(nothing)"] 90.201 μs (5%) 7.19 KiB (1%) 102
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 252.418 ms (5%) 34.800 ms 65.21 MiB (1%) 842077
["JETAnalyzer{SoundPass}", "rand(Bool)"] 50.537 ms (5%) 13.64 MiB (1%) 235380
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 152.901 μs (5%) 18.67 KiB (1%) 238
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 6.725 ms (5%) 1.77 MiB (1%) 31276
["OptAnalyzer", "identity(nothing)"] 151.301 μs (5%) 25.38 KiB (1%) 363
["OptAnalyzer", "println(QuoteNode(nothing))"] 591.630 ms (5%) 53.437 ms 214.10 MiB (1%) 3157757
["OptAnalyzer", "rand(Bool)"] 29.955 ms (5%) 13.66 MiB (1%) 202261
["OptAnalyzer", "sum(\"julia\") (cached)"] 275.202 μs (5%) 57.64 KiB (1%) 790
["OptAnalyzer", "sum(\"julia\")"] 14.894 ms (5%) 5.81 MiB (1%) 86654
["show(::IO, ::JETCallResult)", "report_call"] 5.055 ms (5%) 656.96 KiB (1%) 6893
["show(::IO, ::JETCallResult)", "report_opt"] 21.300 μs (5%) 632 bytes (1%) 14

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.0-DEV.1541
Commit 8d0d012de54 (2023-06-21 16:13 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1039-azure #46-Ubuntu SMP Mon May 22 15:18:07 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 3355 s 0 s 288 s 7942 s 0 s
 #2 2593 MHz 6943 s 0 s 272 s 4371 s 0 s
 Memory: 6.7812042236328125 GB (4451.71875 MB free)
 Uptime: 1165.63 sec
 Load Avg: 1.0 1.0 0.76
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 21 Jun 2023 - 18:44
  • Package commit: f5eba2
  • Julia commit: 8d0d01
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 243.991 ms (5%) 64.73 KiB (1%) 19
["First-Time-To-JET", "rand(Bool)"] 559.885 ms (5%) 65.14 KiB (1%) 19
["First-Time-To-JET", "sum(\"julia\")"] 193.491 ms (5%) 65.14 KiB (1%) 19
["JETAnalyzer{BasicPass} top-level", "demo"] 54.011 ms (5%) 2.26 MiB (1%) 39830
["JETAnalyzer{BasicPass} top-level", "self analysis"] 14.145 s (5%) 972.218 ms 1.26 GiB (1%) 23625513
["JETAnalyzer{BasicPass} top-level", "simple"] 9.250 ms (5%) 1.87 MiB (1%) 32711
["JETAnalyzer{BasicPass}", "identity(nothing)"] 94.801 μs (5%) 7.19 KiB (1%) 102
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 162.653 ms (5%) 38.55 MiB (1%) 727340
["JETAnalyzer{BasicPass}", "rand(Bool)"] 47.149 ms (5%) 12.00 MiB (1%) 220928
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 154.402 μs (5%) 14.77 KiB (1%) 201
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 6.965 ms (5%) 1.70 MiB (1%) 30161
["JETAnalyzer{SoundPass}", "identity(nothing)"] 110.101 μs (5%) 7.19 KiB (1%) 102
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 254.622 ms (5%) 34.714 ms 65.40 MiB (1%) 842101
["JETAnalyzer{SoundPass}", "rand(Bool)"] 48.558 ms (5%) 13.64 MiB (1%) 235380
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 166.102 μs (5%) 18.67 KiB (1%) 238
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 6.824 ms (5%) 1.77 MiB (1%) 31276
["OptAnalyzer", "identity(nothing)"] 141.801 μs (5%) 25.38 KiB (1%) 363
["OptAnalyzer", "println(QuoteNode(nothing))"] 645.658 ms (5%) 59.236 ms 214.10 MiB (1%) 3157757
["OptAnalyzer", "rand(Bool)"] 30.587 ms (5%) 13.66 MiB (1%) 202261
["OptAnalyzer", "sum(\"julia\") (cached)"] 275.802 μs (5%) 57.64 KiB (1%) 790
["OptAnalyzer", "sum(\"julia\")"] 15.048 ms (5%) 5.81 MiB (1%) 86654
["show(::IO, ::JETCallResult)", "report_call"] 5.410 ms (5%) 656.96 KiB (1%) 6893
["show(::IO, ::JETCallResult)", "report_opt"] 25.300 μs (5%) 632 bytes (1%) 14

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.0-DEV.1541
Commit 8d0d012de54 (2023-06-21 16:13 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1039-azure #46-Ubuntu SMP Mon May 22 15:18:07 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 7818 s 0 s 458 s 11405 s 0 s
 #2 2593 MHz 10729 s 0 s 379 s 8570 s 0 s
 Memory: 6.7812042236328125 GB (4523.1484375 MB free)
 Uptime: 1976.47 sec
 Load Avg: 1.0 1.02 0.94
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Runtime information

Runtime Info
BLAS #threads 1
BLAS.vendor() lbt
Sys.CPU_THREADS 2

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 46 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 2
On-line CPU(s) list: 0,1
Vendor ID: GenuineIntel
Model name: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
CPU family: 6
Model: 85
Thread(s) per core: 1
Core(s) per socket: 2
Socket(s): 1
Stepping: 7
BogoMIPS: 5187.81
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 2 MiB (2 instances)
L3 cache: 35.8 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0,1
Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported
Vulnerability L1tf: Mitigation; PTE Inversion
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed: Vulnerable
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown

Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Vendor :Intel
Architecture :Skylake
Model Family: 0x06, Model: 0x55, Stepping: 0x07, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 1024, 36608) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@aviatesk aviatesk merged commit 5845dd6 into master Jun 22, 2023
@aviatesk aviatesk deleted the avi/539 branch June 22, 2023 03:59
@aviatesk aviatesk mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JET doesn't find available method?
2 participants
@aviatesk @codecov-commenter