Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generalize Union{Missing,Bool}->Any widening to other comparison operators #545

Merged
merged 1 commit into from
Jun 26, 2023
Merged

generalize Union{Missing,Bool}->Any widening to other comparison operators #545

merged 1 commit into from
Jun 26, 2023

Conversation

aviatesk
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.49 ⚠️

Comparison is base (6d50525) 89.81% compared to head (7714b43) 88.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
- Coverage   89.81%   88.33%   -1.49%     
==========================================
  Files          10       10              
  Lines        3055     3008      -47     
==========================================
- Hits         2744     2657      -87     
- Misses        311      351      +40
Impacted Files Coverage Δ
src/analyzers/jetanalyzer.jl 87.62% <100.00%> (-0.05%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 26 Jun 2023 - 05:26
  • Baseline: 26 Jun 2023 - 05:40
  • Package commits:
  • Target: 4bcfab
  • Baseline: 6d5052
  • Julia commits:
  • Target: 879f6d
  • Baseline: 879f6d
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["First-Time-To-JET", "rand(Bool)"] 1.13 (5%) ❌ 1.00 (1%)
["First-Time-To-JET", "sum(\"julia\")"] 1.07 (5%) ❌ 1.00 (1%)
["JETAnalyzer{BasicPass}", "rand(Bool)"] 1.08 (5%) ❌ 1.00 (1%)
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 0.88 (5%) ✅ 1.00 (1%)
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 0.93 (5%) ✅ 1.01 (1%)
["OptAnalyzer", "identity(nothing)"] 0.88 (5%) ✅ 1.00 (1%)
["OptAnalyzer", "rand(Bool)"] 0.95 (5%) ✅ 1.00 (1%)
["show(::IO, ::JETCallResult)", "report_call"] 1.09 (5%) ❌ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Target

Julia Version 1.10.0-DEV.1566
Commit 879f6d48242 (2023-06-25 18:12 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1040-azure #47-Ubuntu SMP Thu Jun 1 19:38:24 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2095 MHz 2979 s 0 s 280 s 8405 s 0 s
 #2 2095 MHz 8060 s 0 s 341 s 3285 s 0 s
 Memory: 6.769481658935547 GB (4711.50390625 MB free)
 Uptime: 1178.95 sec
 Load Avg: 1.03 1.03 0.81
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.10.0-DEV.1566
Commit 879f6d48242 (2023-06-25 18:12 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1040-azure #47-Ubuntu SMP Thu Jun 1 19:38:24 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2095 MHz 8174 s 0 s 401 s 11648 s 0 s
 #2 2095 MHz 11606 s 0 s 494 s 8136 s 0 s
 Memory: 6.769481658935547 GB (4679.40625 MB free)
 Uptime: 2036.45 sec
 Load Avg: 1.0 1.03 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 26 Jun 2023 - 5:26
  • Package commit: 4bcfab
  • Julia commit: 879f6d
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 274.988 ms (5%) 64.73 KiB (1%) 19
["First-Time-To-JET", "rand(Bool)"] 647.456 ms (5%) 65.14 KiB (1%) 19
["First-Time-To-JET", "sum(\"julia\")"] 223.856 ms (5%) 65.14 KiB (1%) 19
["JETAnalyzer{BasicPass} top-level", "demo"] 57.012 ms (5%) 2.28 MiB (1%) 39825
["JETAnalyzer{BasicPass} top-level", "self analysis"] 12.975 s (5%) 1.226 s 1.25 GiB (1%) 23456574
["JETAnalyzer{BasicPass} top-level", "simple"] 9.926 ms (5%) 1.85 MiB (1%) 32710
["JETAnalyzer{BasicPass}", "identity(nothing)"] 104.601 μs (5%) 7.19 KiB (1%) 102
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 180.038 ms (5%) 38.63 MiB (1%) 727836
["JETAnalyzer{BasicPass}", "rand(Bool)"] 55.406 ms (5%) 12.01 MiB (1%) 221032
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 151.101 μs (5%) 14.77 KiB (1%) 201
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 7.340 ms (5%) 1.70 MiB (1%) 30162
["JETAnalyzer{SoundPass}", "identity(nothing)"] 101.600 μs (5%) 7.19 KiB (1%) 102
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 270.662 ms (5%) 40.141 ms 65.35 MiB (1%) 842578
["JETAnalyzer{SoundPass}", "rand(Bool)"] 56.017 ms (5%) 13.64 MiB (1%) 235484
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 183.901 μs (5%) 18.67 KiB (1%) 238
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 6.703 ms (5%) 1.77 MiB (1%) 31275
["OptAnalyzer", "identity(nothing)"] 144.001 μs (5%) 25.41 KiB (1%) 363
["OptAnalyzer", "println(QuoteNode(nothing))"] 629.535 ms (5%) 57.314 ms 215.59 MiB (1%) 3155729
["OptAnalyzer", "rand(Bool)"] 33.587 ms (5%) 13.70 MiB (1%) 202308
["OptAnalyzer", "sum(\"julia\") (cached)"] 314.603 μs (5%) 57.67 KiB (1%) 790
["OptAnalyzer", "sum(\"julia\")"] 16.575 ms (5%) 5.82 MiB (1%) 86639
["show(::IO, ::JETCallResult)", "report_call"] 5.485 ms (5%) 656.96 KiB (1%) 6893
["show(::IO, ::JETCallResult)", "report_opt"] 25.301 μs (5%) 632 bytes (1%) 14

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.0-DEV.1566
Commit 879f6d48242 (2023-06-25 18:12 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1040-azure #47-Ubuntu SMP Thu Jun 1 19:38:24 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2095 MHz 2979 s 0 s 280 s 8405 s 0 s
 #2 2095 MHz 8060 s 0 s 341 s 3285 s 0 s
 Memory: 6.769481658935547 GB (4711.50390625 MB free)
 Uptime: 1178.95 sec
 Load Avg: 1.03 1.03 0.81
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 26 Jun 2023 - 5:40
  • Package commit: 6d5052
  • Julia commit: 879f6d
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 280.030 ms (5%) 64.73 KiB (1%) 19
["First-Time-To-JET", "rand(Bool)"] 573.621 ms (5%) 65.14 KiB (1%) 19
["First-Time-To-JET", "sum(\"julia\")"] 209.496 ms (5%) 65.14 KiB (1%) 19
["JETAnalyzer{BasicPass} top-level", "demo"] 57.099 ms (5%) 2.28 MiB (1%) 39825
["JETAnalyzer{BasicPass} top-level", "self analysis"] 13.155 s (5%) 1.193 s 1.25 GiB (1%) 23455314
["JETAnalyzer{BasicPass} top-level", "simple"] 9.994 ms (5%) 1.86 MiB (1%) 32710
["JETAnalyzer{BasicPass}", "identity(nothing)"] 108.501 μs (5%) 7.19 KiB (1%) 102
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 176.815 ms (5%) 38.63 MiB (1%) 727836
["JETAnalyzer{BasicPass}", "rand(Bool)"] 51.210 ms (5%) 12.01 MiB (1%) 221032
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 171.602 μs (5%) 14.77 KiB (1%) 201
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 7.064 ms (5%) 1.70 MiB (1%) 30162
["JETAnalyzer{SoundPass}", "identity(nothing)"] 98.701 μs (5%) 7.19 KiB (1%) 102
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 279.697 ms (5%) 40.308 ms 65.57 MiB (1%) 842614
["JETAnalyzer{SoundPass}", "rand(Bool)"] 56.887 ms (5%) 13.64 MiB (1%) 235484
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 176.502 μs (5%) 18.67 KiB (1%) 238
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 7.188 ms (5%) 1.76 MiB (1%) 31275
["OptAnalyzer", "identity(nothing)"] 163.801 μs (5%) 25.41 KiB (1%) 363
["OptAnalyzer", "println(QuoteNode(nothing))"] 650.047 ms (5%) 59.068 ms 215.59 MiB (1%) 3155729
["OptAnalyzer", "rand(Bool)"] 35.532 ms (5%) 13.70 MiB (1%) 202308
["OptAnalyzer", "sum(\"julia\") (cached)"] 305.303 μs (5%) 57.67 KiB (1%) 790
["OptAnalyzer", "sum(\"julia\")"] 17.185 ms (5%) 5.82 MiB (1%) 86640
["show(::IO, ::JETCallResult)", "report_call"] 5.022 ms (5%) 656.96 KiB (1%) 6893
["show(::IO, ::JETCallResult)", "report_opt"] 26.400 μs (5%) 632 bytes (1%) 14

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.0-DEV.1566
Commit 879f6d48242 (2023-06-25 18:12 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1040-azure #47-Ubuntu SMP Thu Jun 1 19:38:24 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2095 MHz 8174 s 0 s 401 s 11648 s 0 s
 #2 2095 MHz 11606 s 0 s 494 s 8136 s 0 s
 Memory: 6.769481658935547 GB (4679.40625 MB free)
 Uptime: 2036.45 sec
 Load Avg: 1.0 1.03 1.0
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Runtime information

Runtime Info
BLAS #threads 1
BLAS.vendor() lbt
Sys.CPU_THREADS 2

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 46 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 2
On-line CPU(s) list: 0,1
Vendor ID: GenuineIntel
Model name: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
CPU family: 6
Model: 85
Thread(s) per core: 1
Core(s) per socket: 2
Socket(s): 1
Stepping: 4
BogoMIPS: 4190.15
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 2 MiB (2 instances)
L3 cache: 35.8 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0,1
Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported
Vulnerability L1tf: Mitigation; PTE Inversion
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed: Vulnerable
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown

Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Vendor :Intel
Architecture :Skylake
Model Family: 0x06, Model: 0x55, Stepping: 0x04, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 1024, 36608) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@aviatesk aviatesk merged commit 0c40e5a into master Jun 26, 2023
@aviatesk aviatesk deleted the avi/542-again branch June 26, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aviatesk @codecov-commenter