Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Fix sdist lockfile test #9326

Merged
merged 1 commit into from
Feb 26, 2025
Merged

[v2] Fix sdist lockfile test #9326

merged 1 commit into from
Feb 26, 2025

Conversation

hssyoo
Copy link
Contributor

@hssyoo hssyoo commented Feb 26, 2025

GitHub Action that runs on Python 3.12 and macOS 13 is failing sdist tests because 1 of the lockfiles is generated with a newline at the end. This commit strips leading/trailing newlines to ensure consistent comparisons.

@hssyoo hssyoo requested a review from ashovlin February 26, 2025 21:52
Copy link
Member

@ashovlin ashovlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we fixed some of them up manually when merging the performance work since we were adding a new lock file and then moved it. Maybe that threw it off? But seems okay to fix here.

@hssyoo
Copy link
Contributor Author

hssyoo commented Feb 26, 2025

I think we fixed some of them up manually when merging the performance work since we were adding a new lock file and then moved it. Maybe that threw it off? But seems okay to fix here.

This is specifically for source distribution lockfiles and it's oddly only affecting 1 test matrix, so I'd assume they're unrelated. But yeah doing basic sanitization here is a marginal improvement either way.

@hssyoo hssyoo merged commit eb3deb3 into aws:v2 Feb 26, 2025
41 of 45 checks passed
@hssyoo hssyoo deleted the fix-lockfile-test branch February 26, 2025 22:30
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (619640c) to head (1ea37ef).
Report is 21 commits behind head on v2.

Additional details and impacted files
@@    Coverage Diff     @@
##   v2   #9326   +/-   ##
==========================
==========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aemous pushed a commit to aemous/aws-cli that referenced this pull request Mar 3, 2025
aemous pushed a commit to aemous/aws-cli that referenced this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants