Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added special case to handle bucketName #5971

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Conversation

Fred1155
Copy link
Contributor

@Fred1155 Fred1155 commented Mar 18, 2025

Motivation and Context

The .withBucketName(“bucket”) currently transforms to .bucketName(“bucket”), added extra check to handle this case. Will create a map in following PR if more this kind of cases are found.

Modifications

  1. Added checks for method name of "bucketName"

Testing

Added cases in integration test. Will move the test to another Request constructor test file in following PR.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@Fred1155 Fred1155 requested a review from a team as a code owner March 18, 2025 19:49
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Fred1155 Fred1155 added this pull request to the merge queue Mar 18, 2025
Merged via the queue into master with commit b005f25 Mar 18, 2025
17 checks passed
@Fred1155 Fred1155 deleted the bole/fix_bucketname_setter branch March 19, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants