Add support for grouping by different properties by label in Gremlin #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bechbd
requested changes
Apr 23, 2021
There was a problem hiding this comment.
Two things we probably want to think about here:
- We should add unit tests in here to compliment the existing ones and ensure we don't break anything here
- We should update the Visualization-Grouping-Coloring Notebook to include the information on how to use this feature
bechbd
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #97
Description of changes:
Usage:
The variable containing the desired grouping behavior must be formatted as:
groups_var = '{"label_1":{"groupby":"property_1"},"label_2":{"groupby":"property_2"}}'A valueMap step returning the label property and the grouping property(i.e. valueMap(true) or valueMap('~label','property_1'...)) must also be included in the query.
Example:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.