Skip to content

Add all group-less nodes to a default visualization group #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2021

Conversation

michaelnchin
Copy link
Member

@michaelnchin michaelnchin commented Aug 6, 2021

Issue #, if available: #164

Description of changes:

  • If any node is unable to be placed into a visualization group (i.e. a node does not contain the default label property or the grouping property specified with --group-by), place it into a default group to improve the consistency of the graph elements' look and feel.
  • Add --ignore-groups option for OC visualizations
  • More Gremlin visualization bugfixes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@michaelnchin michaelnchin requested a review from krlawrence August 6, 2021 23:01
Copy link
Contributor

@krlawrence krlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a ChangeLog.md update?

@michaelnchin michaelnchin requested a review from krlawrence August 9, 2021 18:02
@michaelnchin
Copy link
Member Author

Thanks for catching that, the changelog is updated now

@michaelnchin michaelnchin merged commit c20cee8 into main Aug 9, 2021
@michaelnchin michaelnchin deleted the DefaultGroups branch August 9, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants