-
Notifications
You must be signed in to change notification settings - Fork 173
Add store-too functionality for magic commands #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -87,10 +97,12 @@ def __init__(self, shell): | |||
super(Graph, self).__init__(shell) | |||
|
|||
try: | |||
self.graph_notebook_config = get_config() | |||
self.config_location = os.getenv('GRAPH_NOTEBOOK_CONFIG', DEFAULT_CONFIG_LOCATION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we will expose to users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not documented yet, but we should add this to our README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one comment as a question on the GRAPH_NOTEBOOK_CONFIG env var.
Issue #, if available: #17
Description of changes:
If a cell throws an exception, we will populate the variable
graph_notebook_error
with the exception. For Example:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.