Skip to content

Add new visualization physics options, and toggle button to enable/disable physics #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 14, 2021

Conversation

michaelnchin
Copy link
Member

@michaelnchin michaelnchin commented Sep 9, 2021

Issue #, if available: #74

Description of changes:

  • Added simulationDuration option: allows setting maximum duration of the simulation, this was previously hardcoded to 1500ms; can also be set using the -sd/--simulation-duration option with query magics
  • Added disablePhysicsAfterInitialSimulation option: disables physics after the first simulation has stabilized; can also be set by specifying-sp/--stop-physics
  • Added new lock/unlock button to graph tab to toggle physics state

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@krlawrence krlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this is a feature that has been on the wanted list for a while

@michaelnchin michaelnchin merged commit cf6f1cf into main Sep 14, 2021
@krlawrence krlawrence mentioned this pull request Sep 16, 2021
@michaelnchin michaelnchin deleted the Physics-Options branch September 17, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants