Skip to content

Add edge tooltips, new query magic option for specifying edge label length #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 3, 2021

Conversation

michaelnchin
Copy link
Member

@michaelnchin michaelnchin commented Oct 27, 2021

Issue #, if available: N/A

Description of changes:

  • Added edge tooltips matching the corresponding edge label, displayed when hovering over any graph edge.
  • Added new -le/--edge-label-max-length (-rel/--rel-label-max-length for %%oc) parameter to query magics for extending and truncating edge labels
  • Added the vertex-specific --label-max-length parameter to %%sparql

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@krlawrence krlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as the -l option for nodes/vertices, I think we should have a similar -el for edge label length truncation control. For %%oc cells we might want to name the parameter -rel to distinguish between. edge and relationship terminology used in the Gremlin and openCypher cases.

@michaelnchin michaelnchin changed the title Display tooltips on visualized edges Add edge tooltips, new query magic option for specifying edge label length Oct 29, 2021
@michaelnchin
Copy link
Member Author

Thank you for the suggestions @krlawrence. I have added a separate parameter for edge label length, which we will now use instead of the -label-max-length input.

@michaelnchin michaelnchin merged commit 82ac40f into main Nov 3, 2021
@michaelnchin michaelnchin deleted the Vis-Edge-Tooltips branch November 3, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants