Skip to content

completed 1st SPARQL guide #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 26, 2022
Merged

completed 1st SPARQL guide #316

merged 12 commits into from
Jul 26, 2022

Conversation

charlesivie
Copy link
Collaborator

Issue #, if available:

Description of changes:

The first of some SPARQL tutorials to be included in the notebooks. This is the basics.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@michaelnchin michaelnchin requested a review from joywa July 6, 2022 18:35
krlawrence
krlawrence requested changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@krlawrence krlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to finish reading but suggested a few upfront wording changes

joywa
joywa reviewed Jul 12, 2022
View reviewed changes
Copy link
Contributor

@joywa joywa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great guide, easy to understand. Some suggestions for consistent formatting and improving customer experience of this notebook.

@joywa
Copy link
Contributor

joywa commented Jul 26, 2022

Worked with @charlesivie offline, latest draft looks good for merging.

krlawrence
krlawrence previously approved these changes Jul 26, 2022
View reviewed changes
@michaelnchin michaelnchin self-requested a review July 26, 2022 23:28
@michaelnchin michaelnchin merged commit e556bee into main Jul 26, 2022
@michaelnchin michaelnchin deleted the SPARQL-TUTORIAL branch July 26, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joywa joywa joywa left review comments

@michaelnchin michaelnchin michaelnchin approved these changes

@krlawrence krlawrence krlawrence left review comments

@bechbd bechbd Awaiting requested review from bechbd

@triggan triggan Awaiting requested review from triggan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@charlesivie @joywa @michaelnchin @krlawrence