Skip to content

Add neptune_config_allowlist magic #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2022
Merged

Add neptune_config_allowlist magic #327

merged 2 commits into from
Jul 18, 2022

Conversation

michaelnchin
Copy link
Member

@michaelnchin michaelnchin commented Jul 15, 2022 •
edited
Loading

Issue #, if available: N/A

Description of changes:

  • Added neptune_config_allowlist line/cell magic. Allows users to modify the allow-list for identifying Neptune endpoints during creation of graph_notebook_config.

For example, the following command:

%%neptune_config_allowlist add

localhost

Outputs:

Set Neptune config allow list to: ['amazonaws.com', 'localhost']

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

phanindhra876
phanindhra876 approved these changes Jul 18, 2022
View reviewed changes
Copy link

@phanindhra876 phanindhra876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verify the failing integ tests before merging.

@michaelnchin michaelnchin merged commit 39590fb into main Jul 18, 2022
@michaelnchin michaelnchin deleted the custom-neptune-hosts branch July 18, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phanindhra876 phanindhra876 phanindhra876 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelnchin @phanindhra876