Skip to content

Security graph notebook #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 17, 2022
Merged

Security graph notebook #373

merged 9 commits into from
Oct 17, 2022

Conversation

bechbd
Copy link
Contributor

@bechbd bechbd commented Sep 27, 2022

Added notebook and sample data set for Security Graphs to the notebook

@bechbd bechbd requested a review from joywa September 27, 2022 23:35
joywa
joywa suggested changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@joywa joywa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great notebook and examples! Left some minor comments. There are a few sentences where there should be a comma to break up the sentence, so I suggest another pass for this to improve readability. Overall, great work!

@joywa
Copy link
Contributor

joywa commented Oct 17, 2022

Changes look good except for a typo - can we fix this for both the notebooks?

@michaelnchin michaelnchin requested a review from joywa October 17, 2022 18:21
@michaelnchin michaelnchin merged commit eb1ffea into main Oct 17, 2022
@michaelnchin michaelnchin deleted the security-graph-notebook branch October 17, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joywa joywa joywa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bechbd @joywa @michaelnchin