Skip to content

Fix/published ports not accessible in host mode #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cubeddu
Copy link
Contributor

@cubeddu cubeddu commented Jun 12, 2023

Issue #, if available: #491
Description of changes:

Update README.md with information on Host Networking Mode

This PR updates the README.md file with information on Host Networking Mode in Docker. Host mode networking can be useful to optimize performance and handle a large range of ports, as it does not require network address translation (NAT), and no "userland-proxy" is created for each port. However, it is important to note that the host networking driver only works on Linux hosts and is not supported on Docker Desktop for Mac, Docker Desktop for Windows, or Docker EE for Windows Server.

This PR also includes examples of how to run a container in host networking mode on a local Mac or Windows machine.

This update provides valuable information to users who may be considering using host networking mode in their Docker containers and ensures that the README.md file is up-to-date and accurate.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

cubeddu and others added 3 commits June 9, 2023 16:37
To resolve the problem of published ports being discarded in the host network mode, delete the "--network='host'" option.
I have included extra documentation on the docker network mode and also added relevant local commands to make it easier to follow.
@michaelnchin
Copy link
Member

Thank you for the contribution, @cubeddu ! Looks good overall, I reorganized a few parts for clarity.

Copy link
Member

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelnchin michaelnchin merged commit 6bb8a0b into aws:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

2 participants