Skip to content

use extras_require to specify tests #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2024
Merged

use extras_require to specify tests #688

merged 3 commits into from
Sep 5, 2024

Conversation

bauer-at-work
Copy link
Contributor

Issue #, if available:

Description of changes:

Specify test dependency in extras_require instead of tests_require.
Reason: The latter is deprecated. See https://github.com/pypa/setuptools/blob/bb0506352435a13f6fd70fa3b9eae6fd0f6e1ea8/docs/references/keywords.rst?plain=1#L452-L467

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

P.S.: This change (together with setting environment variable NODE_OPTIONS="--openssl-legacy-provider" for a totally different reason), allows to specify graph-notebook as a git-based dependency in a pyproject.toml and to install it using poetry:

[tool.poetry.group.dev.dependencies]
graph-notebook = { git = "https://github.com/bauer-at-work/graph-notebook", branch = "main" }

Copy link
Member

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bauer-at-work !

@michaelnchin michaelnchin merged commit 5cd4830 into aws:main Sep 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants