This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Update Proxy settings for installation script #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSM Agent 3.0.1390.0 and later is not using http_proxy setting for HTTPS traffics and setting https_proxy is mandatory.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
SSM Agent 3.0.1390.0 and later is not using http_proxy setting for HTTPS traffics and setting https_proxy is mandatory.
Updated SSM Agent PowerShell installation script to include https_proxy.
The reason is a change in Go version 1.16 net/http.
The ProxyFromEnvironment function no longer returns the setting of the HTTP_PROXY environment variable for https:// URLs when HTTPS_PROXY is unsetHere is more references about the change:
[+] https://go-review.googlesource.com/c/net/+/249440/4/http/httpproxy/proxy.go
[+] golang/go#40909
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.